[rclcpp_action] Action client implementation - #594

Merged

sloretz merged 56 commits into

sservulo_hidmic/rclcpp_action_client

Dec 5, 2018

Commits on Dec 4, 2018

WIP

hidmic
authored and
sloretz
committed
ecf8b5f
Added basic waitable interface to action client

sservulo
authored and
sloretz
committed
ad227d4
Updated waitable execute from action client

sservulo
authored and
sloretz
committed
584ab25
Added throw for rcl calls in action client

sservulo
authored and
sloretz
committed
e221967
Removed duplicated ready flags from action client

sservulo
authored and
sloretz
committed
ce1b068
Minor fix

sservulo
authored and
sloretz
committed
ffcb8bb
Added header to action ClientBaseImpl execute

sservulo
authored and
sloretz
committed
d888fd5
Mich's update to action client interface

sservulo
authored and
sloretz
committed
440ee03
Removed async_cancel from action ClintGoalHandle API

sservulo
authored and
sloretz
committed
0c7dfd8
Added status handler to action client goal handler

sservulo
authored and
sloretz
committed
a94ca35
Added result handler to action client goal handler

sservulo
authored and
sloretz
committed
7fbb253
Identation fix

sservulo
authored and
sloretz
committed
1a1f79a
Added get/set for action client goal handler

sservulo
authored and
sloretz
committed
17a7a8d
Changed action client goal handler attrs from rcl to cpp versions

sservulo
authored and
sloretz
committed
bcf1553
Added check methods to action client goal handler

sservulo
authored and
sloretz
committed
5b2bc4c
Removed rcl_client pointer from action client goal handler

sservulo
authored and
sloretz
committed
6b3482f
Added trailing suffix to client pimpl attrs

sservulo
authored and
sloretz
committed
5967df8
Towards a consistent action client

hidmic
authored and
sloretz
committed
58215f3
Misc fixes for the action client

hidmic
authored and
sloretz
committed
1e9d56e
Yet more misc fixes for the action client

hidmic
authored and
sloretz
committed
5ec7562
Few more fixes and shortcuts to deal with missing type support.

hidmic
authored and
sloretz
committed
68a2e17
Fixed lint errors in action headers and client

hidmic
authored and
sloretz
committed
4275ce7
Fixes to action client internal workflow.

hidmic
authored and
sloretz
committed
9545a0b
Misc fixes to get client example to build
sloretz
committed
ab5df90
More misck client fixes
sloretz
committed
4825f95
Remove debug print
sloretz
committed
f04a50e
replace logging with throw_from_rcl_error
sloretz
committed
750e19b
Wrap result object given by client to user
sloretz
committed
af831b3
Fix a couple bugs trying to cancel goals
sloretz
committed
da9d530
Use unique_indentifier_msgs
sloretz
committed
65fa041
create_client accepts group and removes waitable
sloretz
committed
2faa4b7
Uncrustify fixes
sloretz
committed
7fa9a14

Commits on Dec 5, 2018

[rclcpp_action] Adds tests for action client.

sservulo
authored and
hidmic
committed
7c2c69e
[WIP] Failing action client tests.
hidmic
committed
927115c
[rclcpp_action] Action client tests passing.
hidmic
committed
c2c6775
Spin both executors to make tests pass on my machine
sloretz
committed
ed1af61
Feedback callback uses shared pointer
sloretz
committed
923564b
comment about why make_result_aware is called
sloretz
committed
9e74ca4
Client documentation
sloretz
committed
f7a52eb
Execute one thing at a time
sloretz
committed
8b173d5
Return nullptr instead of throwing RejectedGoalError
sloretz
committed
f1ed490
ClientGoalHandle worries about feedback awareness
sloretz
committed
4dc00d9
cpplint + uncrustify
sloretz
committed
7489e75
Use node logging interface
sloretz
committed
f2dc2ab
ACTION -> ActionT
sloretz
committed
8e0da8f
Make ClientBase constructor protected
sloretz
committed
62c27a4
Return types on different line
sloretz
committed
cc2d038
Avoid passing const reference to temporary
sloretz
committed
5797e51
Child logger rclcpp_action
sloretz
committed
df0a3fa
Child logger rclcpp_action
sloretz
committed
fa391a1
possible windows fixes
sloretz
committed
175213e
remove excess space
sloretz
committed
7cb39d8
swap argument order
sloretz
committed
05cfd8e
Misc test additions
sloretz
committed
9b63b47
Windows independent_bits_engine can't do uint8_t
sloretz
committed
a4b1cb4
Windows link issues
sloretz
committed
ffa4dce