Skip to content

Replace ready_fn with ReadyToTest action #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sloretz merged 1 commit into from
Oct 21, 2019
+6 −6
Merged

Replace ready_fn with ReadyToTest action #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/test_logging_long_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@

from launch import LaunchDescription
from launch.actions import ExecuteProcess
from launch.actions import OpaqueFunction

import launch_testing
import launch_testing.actions
import launch_testing.asserts


def generate_test_description(ready_fn):
def generate_test_description():
launch_description = LaunchDescription()
# Set the output format to a "verbose" format that is expected by the executable output
os.environ['RCUTILS_CONSOLE_OUTPUT_FORMAT'] = \
Expand All @@ -37,7 +37,7 @@ def generate_test_description(ready_fn):
))

launch_description.add_action(
OpaqueFunction(function=lambda context: ready_fn())
launch_testing.actions.ReadyToTest()
)
return launch_description, {'process_name': process_name}

Expand Down
6 changes: 3 additions & 3 deletions test/test_logging_output_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@

from launch import LaunchDescription
from launch.actions import ExecuteProcess
from launch.actions import OpaqueFunction

import launch_testing
import launch_testing.actions
import launch_testing.asserts


def generate_test_description(ready_fn):
def generate_test_description():
processes_to_test = []

launch_description = LaunchDescription()
Expand Down Expand Up @@ -71,7 +71,7 @@ def generate_test_description(ready_fn):
processes_to_test.append(name)

launch_description.add_action(
OpaqueFunction(function=lambda context: ready_fn())
launch_testing.actions.ReadyToTest()
)

return launch_description, {'processes_to_test': processes_to_test}
Expand Down