Skip to content

Extend rmw_qos_policy_kind_t, add functions to convert it to/from a string - #285

Merged
ivanpauno merged 2 commits into
masterfrom
ivanpauno/qos-policy-kind
Oct 19, 2020
Merged

ivanpauno merged 2 commits into
masterfrom
ivanpauno/qos-policy-kind

Conversation

@ivanpauno

Copy link
Copy Markdown
Member

Follow-up of #284.
Useful for ros2/rclcpp#1408.

What this PR does?:

…ition to cover all qos policies

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Oct 19, 2020
@ivanpauno
ivanpauno requested a review from jacobperron October 19, 2020 19:17
@ivanpauno ivanpauno self-assigned this Oct 19, 2020
@ivanpauno ivanpauno mentioned this pull request Oct 19, 2020
10 tasks

@jacobperron jacobperron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ivanpauno

Copy link
Copy Markdown
Member Author
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
ivanpauno merged commit a223f92 into master Oct 19, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the ivanpauno/qos-policy-kind branch October 19, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants