Added ros2interface to replace ros2 msg/srv - #288
Merged
Conversation
added 19 commits
June 20, 2019 17:44
…into kucheria/interface Current branch is stale, need to rebase with master
skucheria
marked this pull request as ready for review
June 24, 2019 23:33
added 2 commits
June 24, 2019 16:56
jacobperron
reviewed
Jun 25, 2019
jacobperron
left a comment
Member
There was a problem hiding this comment.
There can be some refactoring done. Most of the functions should work for generic IDL files, and don't need to make the distinction between "msg", "srv", and "action". For options like --msg-only, we can filter the list based on the second namespace.
This might be a good time to move some of the rosidl-specific logic to another package. Perhaps as a follow-up once we have the functionality working here.
Member
Author
|
jacobperron
reviewed
Jun 26, 2019
jacobperron
left a comment
Member
There was a problem hiding this comment.
Looking good. In addition to addressing the comments below, I think it would be nice to add some unit tests for the functions in ros2interface/api.
jacobperron
reviewed
Jun 27, 2019
jacobperron
left a comment
Member
There was a problem hiding this comment.
To improve test coverage, it would be nice to add more API tests for the remaining functions.
added 3 commits
June 27, 2019 13:13
jacobperron
reviewed
Jun 27, 2019
jacobperron
left a comment
Member
There was a problem hiding this comment.
LGTM, just some nitpicks and small fixes.
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
jacobperron
approved these changes
Jun 27, 2019
Closed
dirk-thomas
reviewed
Jul 29, 2019
|
|
||
| def get_interface_path(parts): | ||
| prefix_path = has_resource('packages', parts[0]) | ||
| joined = '/'.join(parts) |
Member
There was a problem hiding this comment.
This should be a platform specific separator.
| return list(sorted({ | ||
| n[4:-4] | ||
| for n in interface_names | ||
| if n.startswith('srv/') and n[-4:] in ('.idl', '.srv')})) |
Member
There was a problem hiding this comment.
Several of these function look like copy-n-paste with only minimal differences. Please refactor to avoid the duplication. Also we do have a rosidl_runtime_py now so all the TODOs can be addressed.
34 tasks
dirk-thomas
reviewed
Jan 17, 2020
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Aditya <aditya050995@gmail.com> Co-authored-by: Aditya <aditya050995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #223