Skip to content

Alphasort ros2 node list output. - #305

Merged
hidmic merged 1 commit into
masterfrom
hidmic/alphasort-node-list
Jul 29, 2019
Merged

hidmic merged 1 commit into
masterfrom
hidmic/alphasort-node-list

Conversation

@hidmic

@hidmic hidmic commented Jul 29, 2019

Copy link
Copy Markdown

For node name order to be deterministic. Connected to #304.

For node name order to be deterministic.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic added the enhancement New feature or request label Jul 29, 2019
@hidmic
hidmic requested a review from dirk-thomas July 29, 2019 16:02
@hidmic

hidmic commented Jul 29, 2019

Copy link
Copy Markdown
Author

AFAIK there are no tests in master for this section of the codebase. It seems to me that running CI is pointless.

@hidmic

hidmic commented Jul 29, 2019

Copy link
Copy Markdown
Author

Ok going in!

@hidmic
hidmic merged commit 6860105 into master Jul 29, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the hidmic/alphasort-node-list branch July 29, 2019 18:52
skucheria pushed a commit that referenced this pull request Jul 30, 2019
For node name order to be deterministic.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
* Increase test time tolerance

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants