Skip to content

ros2param: consider automatic declaration for 'use_sim_time' - #307

Merged
jubeira merged 1 commit into
masterfrom
jubeira/#395_declare_sim_time
Jul 30, 2019
Merged

jubeira merged 1 commit into
masterfrom
jubeira/#395_declare_sim_time

Conversation

@jubeira

@jubeira jubeira commented Jul 29, 2019

Copy link
Copy Markdown

Connected to ros2/rclpy#396; this fix is needed for CI to pass.

Signed-off-by: Juan Ignacio Ubeira jubeira@ekumenlabs.com

…of 'use_sim_time' parameter.

Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
@jubeira

jubeira commented Jul 30, 2019

Copy link
Copy Markdown
Author

CI (from ros2/rclpy#396 (comment)):

  • Linux: Build Status
  • Linux-aarch64: Build Status
  • OSX: Build Status
  • Windows: Build Status

@hidmic hidmic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jubeira

jubeira commented Jul 30, 2019

Copy link
Copy Markdown
Author

Failures are unrelated known issues; merging now!

@jubeira
jubeira merged commit f8afbed into master Jul 30, 2019
@jubeira
jubeira deleted the jubeira/#395_declare_sim_time branch July 30, 2019 21:34
skucheria pushed a commit that referenced this pull request Jul 30, 2019
…of 'use_sim_time' parameter. (#307)

Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
esteve pushed a commit to esteve/ros2cli that referenced this pull request Dec 16, 2022
Use the newer select interface where available, but fallback
to the dict interface as needed.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants