Uh oh!
There was an error while loading. Please reload this page.
Add null support for constants and defaults - #208
Conversation
Signed-off-by: Ryan Friedman <ryan.friedman@avinc.com>
mjcarroll
commented
Mar 28, 2024
I think this brings up kind of a larger question. By IEEE-754 definition |
To me, they are the same message. You are checking equality of the messages and practically means the contents are the same. For purposes of the equality, I use the operator just before a call to |
mjcarroll
commented
Mar 28, 2024
I'm going to bring this up at our next team meeting, because I think you aren't wrong, but want to make sure that we think through the potential impacts. |
Ryanf55
commented
Jun 5, 2024
Did you get any feedback? I'm still carrying all these patches internally, and would love to get them merged! |
Purpose
Finish out the Null support in ROSIDL_python.
Tests Performed
We've tested this on
humbleand it works great! Note, I added a bunch more checks for equality that should protect against regressions in similar areas.Ticket
Fixes#207
Attribution
This work was contributed on behalf of the MacCreadyWorks department at AeroVironment, Inc