Skip to content

change generators to IDL-based pipeline - #24

Merged
dirk-thomas merged 26 commits into
masterfrom
idl-stage-7
Mar 12, 2019
Merged

change generators to IDL-based pipeline#24
dirk-thomas merged 26 commits into
masterfrom
idl-stage-7

Conversation

@dirk-thomas

@dirk-thomasdirk-thomas commented Nov 21, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Connected to ros2/rosidl#334.

@dirk-thomasdirk-thomas added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
@dirk-thomasdirk-thomas self-assigned this Nov 21, 2018
@dirk-thomasdirk-thomas mentioned this pull request Nov 22, 2018
Merged
@dirk-thomasdirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 26, 2018
hidmic
hidmic reviewed Nov 27, 2018
View reviewed changes
Comment threadrosidl_generator_py/rosidl_generator_py/generate_py_impl.py Outdated
@dirk-thomasdirk-thomas mentioned this pull request Feb 12, 2019
Closed
8 tasks
@dirk-thomasdirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 15, 2019
@dirk-thomasdirk-thomas changed the title update includes and type mappingchange generators to IDL-based pipelineFeb 19, 2019
@mikaelarguedasmikaelarguedas mentioned this pull request Feb 21, 2019
Closed
@dirk-thomasdirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
jacobperron
jacobperron reviewed Feb 22, 2019
View reviewed changes

@jacobperronjacobperron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

FYI, as part of the review I've updated rclpy's ActionServer, which we can add to the idl-stage-7 branch once ros2/rclpy#270 is merged.

Comment threadrosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
Comment threadrosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
Comment threadrosidl_generator_py/resource/_idl_pkg_typesupport_entry_point.c.em Outdated
Comment threadrosidl_generator_py/resource/_idl_pkg_typesupport_entry_point.c.em
Comment threadrosidl_generator_py/resource/_msg.py.em
Comment threadrosidl_generator_py/resource/_msg.py.em
@dirk-thomas
dirk-thomas merged commit abbb86e into masterMar 12, 2019
@dirk-thomas
dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:11
@dirk-thomasdirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019
This was referenced Mar 13, 2019
Closed
Merged
@sloretzsloretz mentioned this pull request Jul 13, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidmichidmichidmic left review comments
@jacobperronjacobperronjacobperron approved these changes

Assignees

@dirk-thomasdirk-thomas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dirk-thomas@jacobperron@hidmic