Skip to content

fix numpy usage for Windows debug builds - #36

Merged
dirk-thomas merged 1 commit into
masterfrom
numpy_windows_debug
Apr 3, 2019
Merged

fix numpy usage for Windows debug builds#36
dirk-thomas merged 1 commit into
masterfrom
numpy_windows_debug

Conversation

@dirk-thomas

@dirk-thomasdirk-thomas commented Apr 2, 2019

Copy link
Copy Markdown
Member

Follow up of #35.

Fixesros2/build_farmer#176.

Depends on ros2/ci#272.

Before: Build Status (failing at test time)
After: Build Status

@dirk-thomasdirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Apr 2, 2019
@dirk-thomasdirk-thomas self-assigned this Apr 2, 2019
@dirk-thomasdirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Apr 2, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas

dirk-thomas commented Apr 3, 2019

Copy link
Copy Markdown
MemberAuthor

Full debug build on Windows: Build Status

The test failures were already present before: e.g. https://ci.ros2.org/view/nightly/job/nightly_win_deb/1202/testReport/

@dirk-thomasdirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 3, 2019
@dirk-thomas
dirk-thomas merged commit acffc81 into masterApr 3, 2019
@delete-merged-branch
delete-merged-branchBot deleted the numpy_windows_debug branch April 3, 2019 22:27
@dirk-thomasdirk-thomas removed the in review Waiting for review (Kanban column) label Apr 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dirk-thomas@mjcarroll