Skip to content

add SLOT_TYPES to each message - #54

Closed
dirk-thomas wants to merge 1 commit into
masterfrom
dirk-thomas/add-slot-types
Closed

add SLOT_TYPES to each message#54
dirk-thomas wants to merge 1 commit into
masterfrom
dirk-thomas/add-slot-types

Conversation

@dirk-thomas

@dirk-thomasdirk-thomas commented May 2, 2019

Copy link
Copy Markdown
Member

Implements a SLOT_TYPES tuple for each message containing the class representation of the type of each slot. This contains part of the implementation from #33 without touching any existing API.

@mikaelarguedas FYI.

Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomasdirk-thomas added enhancement New feature or request in review Waiting for review (Kanban column) labels May 2, 2019
@dirk-thomasdirk-thomas self-assigned this May 2, 2019
@mikaelarguedas

Copy link
Copy Markdown
Member

Changes from this PR have been integrated back into #33. I restored the removed noqa I100 for the generated messages to pass the linters

@dirk-thomas

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #33 then.

@dirk-thomasdirk-thomas removed the in review Waiting for review (Kanban column) label May 3, 2019
@dirk-thomas
dirk-thomas deleted the dirk-thomas/add-slot-types branch May 3, 2019 03:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dirk-thomas@mikaelarguedas