Add test for defered service callback signature - #478
Merged
ivanpauno merged 6 commits intoJul 22, 2021
Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
wjwwood
reviewed
Jul 14, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
wjwwood
approved these changes
Jul 15, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
Author
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
wjwwood
approved these changes
Jul 19, 2021
Member
Author
|
Last commit should've fixed the CI issues |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
Author
|
Finally got windows CI passing: ros2/rclcpp#1709 (comment). |
wjwwood
approved these changes
Jul 20, 2021
Member
Author
|
@ros-pull-request-builder retest this please |
delete-merged-branch
Bot
deleted the
ivanpauno/support-defered-response-in-services
branch
July 22, 2021 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ros2/rclcpp#1709