build: complete test-signing lifecycle in CI - #3
Merged
Merged
Conversation
Create a non-exportable per-build signing key, require SignTool kernel-policy verification in CI, and remove temporary machine trust and private key material before artifact upload. Co-authored-by: Roxy <299891354+roxy-commits@users.noreply.github.com>
Use SignTool's Authenticode policy for self-signed research drivers and add an always-run guard that rejects leftover test certificates or private keys. Co-authored-by: Roxy <299891354+roxy-commits@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Note
SignTool /kp requires a Microsoft-rooted production driver-signing chain and correctly rejects a self-signed research certificate. This pipeline uses /pa to verify the embedded SHA-256 Authenticode signature and separately checks that the embedded signer thumbprint equals the generated certificate. Loading remains limited to Windows test-signing mode; production loading requires Microsoft attestation or WHQL signing.