chore: make all identifiers snake case - #115
Open
rozukke wants to merge 4 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Cpp-Linter Report |
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v14.0.6
Click here for the full clang-format patch
diff --git a/example/pyramid.cpp b/example/pyramid.cpp
index 9e9249c..d28bfb9 100644
--- a/example/pyramid.cpp+++ b/example/pyramid.cpp@@ -13 +13,2 @@ void make_ring(mcpp::Coordinate base_pt, int side_len) {
- mc.set_blocks(base_pt, base_pt + mcpp::Coordinate(side_len, 0, side_len), mcpp::Blocks::SANDSTONE);+ mc.set_blocks(base_pt, base_pt + mcpp::Coordinate(side_len, 0, side_len),+ mcpp::Blocks::SANDSTONE);@@ -18 +19 @@ void make_ring(mcpp::Coordinate base_pt, int side_len) {
- mcpp::Blocks::AIR);+ mcpp::Blocks::AIR);diff --git a/include/mcpp/block.h b/include/mcpp/block.h
index dc9ce79..747ae11 100644
--- a/include/mcpp/block.h+++ b/include/mcpp/block.h@@ -17 +17 @@ public:
- constexpr BlockType(uint8_t id = 0, uint8_t mod = 0) : id(id), mod(mod) {};+ constexpr BlockType(uint8_t id = 0, uint8_t mod = 0) : id(id), mod(mod){};Have any feedback or feature suggestions? Share it here.
| void make_ring(mcpp::Coordinate base_pt, int side_len) { | ||
| // Flat plane | ||
| mc.setBlocks(base_pt, base_pt + mcpp::Coordinate(side_len, 0, side_len), mcpp::Blocks::SANDSTONE); | ||
| mc.set_blocks(base_pt, base_pt + mcpp::Coordinate(side_len, 0, side_len), mcpp::Blocks::SANDSTONE); |
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| mc.set_blocks(base_pt, base_pt + mcpp::Coordinate(side_len, 0, side_len), mcpp::Blocks::SANDSTONE); | |
| mc.set_blocks(base_pt, base_pt + mcpp::Coordinate(side_len, 0, side_len), | |
| mcpp::Blocks::SANDSTONE); |
| base_pt = base_pt + mcpp::Coordinate(1, 0, 1); | ||
| mc.setBlocks(base_pt, base_pt + mcpp::Coordinate(side_len - 2, 0, side_len - 2), | ||
| mc.set_blocks(base_pt, base_pt + mcpp::Coordinate(side_len - 2, 0, side_len - 2), | ||
| mcpp::Blocks::AIR); |
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| mcpp::Blocks::AIR); | |
| mcpp::Blocks::AIR); |
| // NOLINTNEXTLINE | ||
| constexpr BlockType(uint8_t id = 0, uint8_t mod = 0) : id(id), mod(mod){}; | ||
| constexpr BlockType(uint8_t id = 0, uint8_t mod = 0) : id(id), mod(mod){}; |
Contributor
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| constexpr BlockType(uint8_tid=0, uint8_tmod=0) : id(id), mod(mod){}; | |
| constexpr BlockType(uint8_tid=0, uint8_tmod=0) : id(id), mod(mod){}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overdue. Also needs a vibe check.