Skip to content

Re-add exclude_runtime_main_js runtime feature#421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayvdb wants to merge 1 commit into
base:master
Choose a base branch
from
Open

Re-add exclude_runtime_main_js runtime feature #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -240,7 +240,7 @@ base64-simd = {version = "0.8.0", optional = true}
# Dependencies for the node feature
deno_resolver = { version = "^0.59.0", optional = true }
node_resolver = { version = "^0.66.0", optional = true, features = ["sync"] }
deno_runtime = { version = "^0.236.0", optional = true, features = ["exclude_runtime_main_js"] }
deno_runtime = { version = "^0.236.0", optional = true }
deno_terminal = { version = "^0.2.3", optional = true }
deno_semver = { version = "^0.9.1", optional = true }
deno_napi = { version = "^0.159.0", optional = true }
Expand Down
10 changes: 4 additions & 6 deletions src/ext/runtime/mod.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ use deno_bundle_runtime::BundleProvider;
use deno_core::{
extension,
v8::{BackingStore, SharedRef},
CrossIsolateStore, Extension, ExtensionFileSource,
CrossIsolateStore, Extension,
};
use deno_runtime::deno_permissions::Permissions;
use deno_runtime::permissions::RuntimePermissionDescriptorParser;
Expand DownExpand Up@@ -54,11 +54,6 @@ extension!(
let permissions = build_permissions(container);
state.put(permissions);
},
customizer = |e: &mut Extension| {
e.esm_files.to_mut().push(
ExtensionFileSource::new("ext:deno_features/flags.js", deno_features::JS_SOURCE)
);
}
);
impl ExtensionTrait<()> for init_runtime {
fn init((): ()) -> Extension {
Expand All@@ -70,6 +65,9 @@ impl ExtensionTrait<()> for deno_runtime::runtime {
fn init((): ()) -> Extension {
let mut e = deno_runtime::runtime::init();
e.esm_entry_point = None;
e.esm_files
.to_mut()
.retain(|f| f.specifier != "ext:runtime_main/js/99_main.js");
e
}
}
Expand Down