Skip to content

fix: avoid panic in as_highlighted when column_number is 0#424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base:master
Choose a base branch
from
Open

fix: avoid panic in as_highlighted when column_number is 0 #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/error.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -142,7 +142,7 @@ impl Error {
};

let mut line = e.source_line.as_ref().map(|s| s.trim_end());
let col = col - 1;
let col = col.saturating_sub(1);

// Get at most 50 characters, centered on column_number
let mut padding = String::new();
Expand DownExpand Up@@ -320,4 +320,29 @@ mod test {
"= Uncaught (in promise) ReferenceError: x is not defined"
));
}

#[test]
fn highlight_with_zero_column_does_not_panic() {
let js_error = deno_core::error::JsError {
name: Some("ReferenceError".to_string()),
message: Some("x is not defined".to_string()),
stack: None,
cause: None,
exception_message: "Uncaught ReferenceError: x is not defined".to_string(),
frames: vec![deno_core::error::JsStackFrame::from_location(
Some("file:///test.js".to_string()),
Some(1),
Some(0),
)],
source_line: Some("const x = y;".to_string()),
source_line_frame_index: Some(0),
aggregated: None,
additional_properties: vec![],
};

let err = crate::Error::from(Box::new(js_error));
let out = err.as_highlighted(ErrorFormattingOptions::default());
assert!(out.contains("const x = y;"));
assert!(out.contains("ReferenceError"));
}
}