Uh oh!
There was an error while loading. Please reload this page.
TcpDuplexConnection supports multiple subscribes - #334
Closed
lehecka wants to merge 18 commits into
Closed
Conversation
lehecka
commented
Mar 31, 2017
ContributorAuthor
All implementations of DuplexConnection should support repeated connecting to input/output. |
facebook-github-bot
commented
Mar 31, 2017
@lehecka has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
alexmalyshev
approved these changes
May 9, 2017
alexmalyshev
left a comment
Contributor
There was a problem hiding this comment.
lgtm. inline nits are not blocking
| std::shared_ptr<Subscription> subscription) noexcept override { | ||
| if (tcpReaderWriter_) { | ||
| // no flow control at tcp level, since we can't know the size of messages | ||
| subscription->request(std::numeric_limits<size_t>::max()); |
Contributor
There was a problem hiding this comment.
Is this necessary? It seems like in the next line, TcpReaderWriter::setOutputSubscription() will also do request(SIZE_T_MAX).
| } | ||
| void requestImpl(size_t n) noexcept override { | ||
| // TcpDuplexConnection doesnt support propper flow control |
lehecka
commented
May 18, 2017
ContributorAuthor
replaced with #458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.