Uh oh!
There was an error while loading. Please reload this page.
fixing memory leaking tests - #437
Merged
Merged
Conversation
alexmalyshev
commented
May 16, 2017
Contributor
The change seems like a good idea to me, I never liked the Build is still failing though, so please fix and re-test everything with ASAN+LSAN if you can. |
alexmalyshev
approved these changes
May 16, 2017
lehecka
commented
May 17, 2017
ContributorAuthor
this is not fixing all travis issues, but fixes the memory leaking. I will commit this now and work on fixing the rest of the travis issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Subscription interface is now used in ReactiveSocket library and the special behavior around lifetime is unnecessary and awkward to use leading to memory leaks.
The fix also focuses on breaking the reference cycles between subscribers and subscriptions