Uh oh!
There was an error while loading. Please reload this page.
Eliminate ReactiveSocket.h - #442
Merged
lehecka merged 4 commits intoMay 17, 2017
Merged
Conversation
... but it's copy/pasted into /test and still used by tests and tck which will need to be dealt with later
benjchristensen
commented
May 17, 2017
ContributorAuthor
failure is known and being worked on in other pull requests |
lehecka
approved these changes
May 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request eliminates ReactiveSocket.h from the /src/ folder. It is still used by unit and tck tests for now (by moving into /tests/) as I wanted to decouple those changes from this one.
RSocketServer and RSocketClient now interact directly with the RSocketStateMachine.