Uh oh!
There was an error while loading. Please reload this page.
Purge Obsolete Unit Tests - #445
Merged
Merged
Conversation
Most tests are now obsolete as they use old Subscriber/Subscription types and old ReactiveSocket.h APIs. It was decided that it is much easier to clean house and rewrite new unit tests against the new APIs, so purging and will start rewriting over next couple days (after a few more API changes this purge make easier).
- no more separate rsocket_tests - yarpl is no longer in the experimental folder
benjchristensen
commented
May 17, 2017
ContributorAuthor
ASAN failure on a yarpl test. I didn't touch yarpl :-/ |
lehecka
approved these changes
May 17, 2017
lehecka
left a comment
Contributor
There was a problem hiding this comment.
Holding Ben's hand to support him ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most tests are now obsolete as they use old Subscriber/Subscription types and old ReactiveSocket.h APIs.
It was decided that it is much easier to clean house and rewrite new unit tests against the new APIs, so purging and will start rewriting over next couple days (after a few more API changes this purge make easier).