Skip to content

Separating RSocket connection lifetime management into RSocketConnectionManager - #505

Merged
lehecka merged 8 commits into
rsocket:masterfrom
lehecka:RSocketConnectionManager
Jun 7, 2017
Merged

Separating RSocket connection lifetime management into RSocketConnectionManager#505
lehecka merged 8 commits into
rsocket:masterfrom
lehecka:RSocketConnectionManager

Conversation

@lehecka

@leheckalehecka commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

tested on examples with vlog level set to 3 to see the extra logging. All works as expected.

Both client and server RSocket instances now share the same lifetime management. The key behavior elements are:

  • all RSocket instances are closed when the RSocketClient/RSocketServer objects are destroyed.
  • when the RSocket is closed from the other side, it is automatically removed from the collection of active RSocket instances
  • user code can explicitly close the RSocket via RSocketRequester::close

@lehecka
lehecka merged commit 091dfb2 into rsocket:masterJun 7, 2017
@lehecka

Copy link
Copy Markdown
ContributorAuthor

merging to unblock the following PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@lehecka