Uh oh!
There was an error while loading. Please reload this page.
[rsocket-cpp] Enable tck tests in travis builds - #510
Merged
Conversation
somasun
commented
Jun 9, 2017
- Enable tck tests to run in travis builds
- Make the server terminate with signal (instead of stdin - which doesnt work well with background jobs)
- Reuse the same requester for all requests
lehecka
commented
Jun 9, 2017
Contributor
looks like there are 2 test issues in travis. |
alexmalyshev
approved these changes
Jun 13, 2017
| folly::SocketAddress address; | ||
| address.setFromHostPort(FLAGS_ip, FLAGS_port); | ||
| LOG(INFO) << "Creating client to connect to " << address.describe(); |
Contributor
There was a problem hiding this comment.
operator<<(std::ostream&, const folly::SocketAddress&) already exists I think, no need for .describe().
| const Test& test, | ||
| std::unique_ptr<RSocketRequester> requester) | ||
| : requester_(std::move(requester)), test_(test) { | ||
| RSocketRequester* requester) |
Contributor
There was a problem hiding this comment.
I would probably have this as RSocketRequester&, but this is fine too.
| static void signal_handler(int signal) { | ||
| LOG(INFO) << "Terminating program after receiving signal " << signal; | ||
| exit(signal); | ||
| terminate.set_value(); |
Contributor
There was a problem hiding this comment.
What are the chances this is safe to do in a signal handler... Regardless, I don't have a better solution as SignalBarrier isn't open source and it's very likely Linux-only code.
Any particular reason for std::future instead of folly::Future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.