Skip to content

Delete SubscriptionHelper.{cpp,h} - #516

Merged
alexmalyshev merged 2 commits into
rsocket:masterfrom
alexmalyshev:delete-subscription-helper
Jun 19, 2017
Merged

Delete SubscriptionHelper.{cpp,h}#516
alexmalyshev merged 2 commits into
rsocket:masterfrom
alexmalyshev:delete-subscription-helper

Conversation

@alexmalyshev

Copy link
Copy Markdown
Contributor

These aren't used anymore as they were replaced by credits.{cpp,h}.

These aren't used anymore as they were replaced by credits.{cpp,h}.
@phoad

Copy link
Copy Markdown
Member

Looks like there is no reference to these files in the CMakeLists.txt either.
LGTM.

@phoad

Copy link
Copy Markdown
Member

Do you know why it is named Credits.h/cpp?

@alexmalyshev

Copy link
Copy Markdown
ContributorAuthor

Because the functionality in those files is all about adding, consuming, and cancelling credits.

@alexmalyshev
alexmalyshev merged commit e8cb2f2 into rsocket:masterJun 19, 2017
@alexmalyshev
alexmalyshev deleted the delete-subscription-helper branch June 19, 2017 18:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmalyshev@phoad