Uh oh!
There was an error while loading. Please reload this page.
Use container-based Travis infra - #532
Merged
Merged
Conversation
alexmalyshev
approved these changes
Jun 20, 2017
alexmalyshev
left a comment
Contributor
There was a problem hiding this comment.
Well that makes things easier.
phoad
approved these changes
Jun 20, 2017
| - if [ -n "$GCC_VERSION" -a "$ASAN" == "On" ]; then CXX_FLAGS="${CXX_FLAGS} -fsanitize=address,undefined -fuse-ld=gold"; fi | ||
| - if [ -n "$GCC_VERSION" ]; then CXX_FLAGS="${CXX_FLAGS} --coverage"; fi # enable code coverage on GCC builds | ||
| - cmake .. -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_CXX_FLAGS="${CXX_FLAGS}" -DCMAKE_EXE_LINKER_FLAGS="${CXX_LINKER_FLAGS}" -DMETA_CXX_STD=$CPP_VERSION | ||
| - cmake .. -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_CXX_FLAGS="${CXX_FLAGS}" -DMETA_CXX_STD=$CPP_VERSION -DFOLLY_INSTALL_DIR=$HOME/folly |
Member
There was a problem hiding this comment.
Don't we need the Linker_Flags anymore?
ContributorAuthor
There was a problem hiding this comment.
They are not set anywhere (looks like copypasta).
phoad
commented
Jun 20, 2017
Member
I will do Close/Open to rerun the build. |
vitaut
commented
Jun 20, 2017
ContributorAuthor
The "Broken promise" error looks unrelated and has been there before (e.g. https://travis-ci.org/rsocket/rsocket-cpp/jobs/243859522). |
vitaut
commented
Jun 20, 2017
ContributorAuthor
BTW you can trigger the build via Travis without closing/opening PRs. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the Travis config from legacy to container-based infrastructure and caches built folly binaries giving almost 4x build speed up (from ~16 min to ~4 min).
Before:
After:
Other improvements:
.travis.yml.Vagrantfile.FOLLY_LIBRARYDIRandFOLLY_INCLUDEDIRwith a singleFOLLY_INSTALL_DIRCMake variable.