Skip to content

Pre-validate Payload length at stream level to avoid closing connection - #768

Merged
OlegDokuka merged 11 commits into
developfrom
bugfix/frame-length-validation
Apr 9, 2020
Merged

Pre-validate Payload length at stream level to avoid closing connection #768
OlegDokuka merged 11 commits into
developfrom
bugfix/frame-length-validation

Conversation

@OlegDokuka

@OlegDokukaOlegDokuka commented Apr 5, 2020

Copy link
Copy Markdown
Member

This PR provide extra payload validation in order to avoid later exception throwing if frame length exists allowed size for with disabled fragmentation

@OlegDokukaOlegDokuka added this to the 1.0 milestone Apr 5, 2020
@OlegDokukaOlegDokuka linked an issue Apr 5, 2020 that may be closed by this pull request
Netty channel hangs after sending a payload of size > 16 MB #742
Closed
@OlegDokuka
OlegDokuka changed the base branch from develop to bugfix/request_channelApril 5, 2020 11:38
@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch 3 times, most recently from b21e1b9 to 1c05255CompareApril 5, 2020 13:57
@OlegDokukaOlegDokuka self-assigned this Apr 5, 2020
@OlegDokuka
OlegDokukaforce-pushed the bugfix/request_channel branch 2 times, most recently from 5339a88 to 268e1aeCompareApril 5, 2020 14:02
@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch from 1c05255 to a124aeaCompareApril 5, 2020 14:47
simonbasle
simonbasle requested changes Apr 6, 2020
View reviewed changes
Comment threadrsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationUtils.java Outdated
Comment threadrsocket-core/src/main/java/io/rsocket/RSocketRequester.java Outdated
rstoyanchev
rstoyanchev requested changes Apr 8, 2020
View reviewed changes
Comment threadrsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationUtils.java Outdated
Comment threadrsocket-core/src/main/java/io/rsocket/RSocketRequester.java Outdated
@rstoyanchevrstoyanchev mentioned this pull request Apr 8, 2020
Closed
@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch from 09686c2 to 5921ef3CompareApril 9, 2020 11:48
@OlegDokuka
OlegDokukaforce-pushed the bugfix/request_channel branch from 268e1ae to ab0ce37CompareApril 9, 2020 11:52
@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch from 5921ef3 to d4a9633CompareApril 9, 2020 11:53
rstoyanchev
rstoyanchev approved these changes Apr 9, 2020
View reviewed changes

@rstoyanchevrstoyanchev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlegDokuka

OlegDokuka commented Apr 9, 2020

Copy link
Copy Markdown
MemberAuthor

Deferred until #736

@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch from 225c0d9 to c4f56e3CompareApril 9, 2020 12:47
@OlegDokuka
OlegDokuka changed the base branch from bugfix/request_channel to developApril 9, 2020 17:07
@OlegDokuka
provides failing test
ca498ec
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
provides requestChannel bugfix
c092f73
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
more fixes
781819e
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
rollbacks unwanted changes
b7522b6
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
initial
43e3e39
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
provides payload length validation in case fragmentation is disabled
d5c67f2
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
provides payload validation
7e93ab9
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
fixes tests and changes error message
c6ee7ee
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
moves validator to core package and makes it pkg private
7adafdb
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
simplifies validation utils. puts error message to constant field
ab7ff18
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch from 0ac7944 to 22ee087CompareApril 9, 2020 18:42
@OlegDokuka
fixes IDE warning
f8676af
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
@OlegDokuka
OlegDokukaforce-pushed the bugfix/frame-length-validation branch from 22ee087 to f8676afCompareApril 9, 2020 18:48
@OlegDokuka
OlegDokuka merged commit c2475c2 into developApr 9, 2020
@OlegDokuka
OlegDokuka deleted the bugfix/frame-length-validation branch April 9, 2020 20:13
@rstoyanchevrstoyanchev modified the milestones: 1.0, 1.0.0-RC7Apr 17, 2020
@rstoyanchevrstoyanchev changed the title Payload length validationPre-validate Payload length at stream level to avoid closing connection Apr 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rstoyanchevrstoyanchevrstoyanchev approved these changes
@simonbaslesimonbasleAwaiting requested review from simonbasle

Assignees

@OlegDokukaOlegDokuka

Labels

bug

Projects

None yet

Milestone

1.0 RC7

Development

Successfully merging this pull request may close these issues.

Netty channel hangs after sending a payload of size > 16 MB

3 participants

@OlegDokuka@rstoyanchev@simonbasle