Uh oh!
There was an error while loading. Please reload this page.
provides reworked AeronTransport implementation - #972
Conversation
| public BaseDuplexConnection() { | ||
| onClose.doFinally(s -> doOnClose()).subscribe(); | ||
| onClose.subscribe(null, t -> doOnClose(), this::doOnClose); |
There was a problem hiding this comment.
unrelated, non-blocking. What's the plan with the deprecation? reactor/reactor-core#2431 (comment)
Should onClose be updated?
There was a problem hiding this comment.
Yeah. I will do that in a separate PR
| public BaseDuplexConnection() { | ||
| onClose.doFinally(s -> doOnClose()).subscribe(); | ||
| onClose.subscribe(null, t -> doOnClose(), this::doOnClose); |
There was a problem hiding this comment.
Does this still run for cancellation?
There was a problem hiding this comment.
I dont think it should at all. In this case, we wait for onError or onComplete
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| .subscribe( | ||
| null, | ||
| __ -> { | ||
| synchronized (activeConnections) { |
There was a problem hiding this comment.
Can this duplication be improved by using doOnTerminate or doFinally?
Uh oh!
There was an error while loading. Please reload this page.
yschimke
commented
Jan 2, 2021
Low value drive by review of a draft PR. Mainly me trying to learn from the PR. |
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
…on/AeronClientTransport.java Co-authored-by: Yuri Schimke <yuri@schimke.ee>
…on/AeronServerTransport.java Co-authored-by: Yuri Schimke <yuri@schimke.ee>
uncomments largePayload tests Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
0753b6e to
6aa3d8aCompare
Signed-off-by: Oleh Dokuka shadowgun@i.ua