Uh oh!
There was an error while loading. Please reload this page.
adds jcstress for requester and responder operators - #999
Merged
Conversation
OlegDokukaforce-pushed
the
enhancement/jcstresstests
branch
from
March 27, 2021 22:08
18c96b4 to
de54cfdComparerstoyanchev
requested changes
Apr 1, 2021
| Operators.onErrorDropped(t, Context.empty()); | ||
| return; | ||
| } | ||
Contributor
There was a problem hiding this comment.
Also update the copy in loadbalance?
| import reactor.core.publisher.Operators; | ||
| import reactor.util.context.Context; | ||
| public class StressSubscriber<T> implements CoreSubscriber<T> { |
Contributor
There was a problem hiding this comment.
StressTestSubscriber perhaps?
| import reactor.core.CoreSubscriber; | ||
| import reactor.core.publisher.Operators; | ||
| public class StressSubscription<T> implements Subscription { |
Contributor
There was a problem hiding this comment.
Likewise StressTestSubscription
Comment on lines
+61
to
+82
| public volatile boolean concurrentOnNext; | ||
| public volatile boolean concurrentOnError; | ||
| public volatile boolean concurrentOnComplete; | ||
| public volatile boolean concurrentOnSubscribe; |
Contributor
There was a problem hiding this comment.
These are set but not used. Am I missing something? There are others that are not used as well like droppedErrors, onNextDiscarded, and error.
MemberAuthor
There was a problem hiding this comment.
it is ported from reactor-core and should be used in the upcoming updates
OlegDokukaforce-pushed
the
enhancement/jcstresstests
branch
7 times, most recently
from
May 20, 2021 09:30
893b7ea to
3296d72CompareOlegDokuka
marked this pull request as ready for review
May 24, 2021 09:12
OlegDokukaforce-pushed
the
enhancement/jcstresstests
branch
4 times, most recently
from
May 24, 2021 13:46
20ad9dc to
c81c408Compare8 tasks
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
OlegDokukaforce-pushed
the
enhancement/jcstresstests
branch
from
June 7, 2021 13:01
c81c408 to
61cf1cfCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds JCStressTests Support
Motivation:
JCStress is a proven tool for making sure correctness of concurrency model used in various places
Modifications:
Adds list of JCStress tests
Result:
Better verification of concurrency related issues
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com