Uh oh!
There was an error while loading. Please reload this page.
chore(deps): update dependency puppeteer to v25 - #219
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
renovateBotforce-pushed
the
renovate/major-puppeteer
branch
4 times, most recently
from
May 19, 2026 16:02
71d587e to
e8901d0ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
3 times, most recently
from
May 28, 2026 16:15
83de691 to
6fff65fComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
June 3, 2026 03:01
6fff65f to
433ba6aComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
June 13, 2026 19:52
433ba6a to
65d4145Compare📝 WalkthroughWalkthroughThis pull request updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 80: The puppeteer bump in package.json (the "puppeteer" dependency)
conflicts with the declared engines.node range (engines.node) because
puppeteer@25 requires node >=22.12.0 and our test/install script
(scripts/install-puppeteer-browser.mjs) imports Puppeteer at install time; fix
by either 1) pinning "puppeteer" in package.json to a version that still
supports Node 20 (choose a 24.x release known to support Node 20) so the current
engines.node range remains valid, or 2) raising package.json's engines.node to
">=22.12.0" (and update docs/automation and any developer notes and ensure
.github/workflows/test.yml / CI Node versions align) so the declared node
support matches puppeteer@25; apply only one of these fixes and update
pnpm-lock.yaml by reinstalling dependencies.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a1e518c1-b152-498f-a2f1-51d297fbe8ae
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
| "p-retry": "^7.1.1", | ||
| "prettier": "3.8.3", | ||
| "puppeteer": "^24.43.1", | ||
| "puppeteer": "^25.1.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== Root engine declaration =="
jq -r '.engines.node' package.json
echoecho"== Puppeteer engine requirements from lockfile =="
rg -n -A2 -B1 'puppeteer(@|-)25\.1\.0|engines:\s*\{node:\s*' pnpm-lock.yaml
echoecho"== Test scripts that require Puppeteer =="
jq -r '.scripts | to_entries[] | select(.key|test("test")) | "\(.key): \(.value)"' package.json
echoecho"== CI/workflow node-version references (if present) =="
fd -HI '.*\.(yml|yaml)$' .github/workflows 2>/dev/null \
| xargs -r rg -n -C2 'setup-node|node-version|matrix'Repository: rstackjs/rspack-dev-server
Length of output: 36815
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== package.json (around engines + dependency section) =="
nl -ba package.json | sed -n '60,120p'echoecho"== scripts/install-puppeteer-browser.mjs (imports/usage) =="if [ -f scripts/install-puppeteer-browser.mjs ];then
nl -ba scripts/install-puppeteer-browser.mjs | sed -n '1,200p'elseecho"Missing scripts/install-puppeteer-browser.mjs"fiechoecho"== CI workflows (node-version references) =="
fd -HI '.*\.(yml|yaml)$' .github/workflows \
| xargs -r rg -n -C1 'setup-node|node-version|matrix'echoecho"== engine-strict config (npm/pnpm/yarn) =="
ls -la | rg -n '\.npmrc|\.pnpmrc|\.yarnrc|packageManager\.yml'||trueforfin .npmrc .pnpmrc .yarnrc .yarnrc.yml packageManager.yml;doif [ -f"$f" ];thenecho"--- $f ---"
cat -n "$f"fidoneRepository: rstackjs/rspack-dev-server
Length of output: 188
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== package.json (around engines + dependency section) =="
sed -n '1,140p' package.json | cat -n
echoecho"== scripts/install-puppeteer-browser.mjs (imports/usage) =="if [ -f scripts/install-puppeteer-browser.mjs ];then
sed -n '1,220p' scripts/install-puppeteer-browser.mjs | cat -n
elseecho"Missing scripts/install-puppeteer-browser.mjs"fiechoecho"== CI workflows (node-version references) =="
fd -HI '.*\.(yml|yaml)$' .github/workflows \
| xargs -r rg -n -C1 'setup-node|node-version|matrix'||trueechoecho"== engine-strict config (.npmrc/.pnpmrc/.yarnrc) =="forfin .npmrc .pnpmrc .yarnrc .yarnrc.yml packageManager.yml;doif [ -f"$f" ];thenecho"--- $f ---"
sed -n '1,120p'"$f"| cat -n
fidoneRepository: rstackjs/rspack-dev-server
Length of output: 8497
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== Search for engine-strict / engines enforcement =="
rg -n --hidden --glob '!.git''engine-strict|engine strict|enginesStrict|pnpm.*engine|npm.*engine'.echoecho"== Check if README/docs mention supported Node versions =="
rg -n --hidden --glob '!.git''Node (>=|js )?(20|22)|node-version|engines\.node|supported Node' README* docs*.||trueRepository: rstackjs/rspack-dev-server
Length of output: 123
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== Search for engine-strict enforcement knobs =="
rg -n --hidden --glob '!.git''engine-strict|engineStrict|ENGINES_STRICT'.echoecho"== Search for pnpm config section mentioning engines =="
rg -n --hidden --glob '!.git''engines' .npmrc .pnpmrc pnpm-workspace.yaml package.json 2>/dev/null ||trueRepository: rstackjs/rspack-dev-server
Length of output: 119
Fix Puppeteer/Node engine contract mismatch
package.json declares Node support ^20.19.0 || >=22.12.0 (line 100), but bumping puppeteer to ^25.1.0 (line 80) pulls puppeteer@25.1.0 / puppeteer-core@25.1.0 which require node >=22.12.0 (pnpm-lock.yaml). This repo’s pnpm test runs test:install → scripts/install-puppeteer-browser.mjs, which imports Puppeteer and installs Chrome, so Node 20 contributors are likely to hit install/runtime failures. CI is already pinned to Node 24.16.0 in .github/workflows/test.yml, so the mismatch is primarily for local Node 20 runs.
Remediation options:
- Pin Puppeteer to a version that supports Node 20 while keeping the current
engines.node, or - Raise
package.json#engines.nodeto>=22.12.0(and align any docs/automation) so the declared support matches test/runtime tooling.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 80, The puppeteer bump in package.json (the "puppeteer"
dependency) conflicts with the declared engines.node range (engines.node)
because puppeteer@25 requires node >=22.12.0 and our test/install script
(scripts/install-puppeteer-browser.mjs) imports Puppeteer at install time; fix
by either 1) pinning "puppeteer" in package.json to a version that still
supports Node 20 (choose a 24.x release known to support Node 20) so the current
engines.node range remains valid, or 2) raising package.json's engines.node to
">=22.12.0" (and update docs/automation and any developer notes and ensure
.github/workflows/test.yml / CI Node versions align) so the declared node
support matches puppeteer@25; apply only one of these fixes and update
pnpm-lock.yaml by reinstalling dependencies.
renovateBotforce-pushed
the
renovate/major-puppeteer
branch
2 times, most recently
from
June 20, 2026 17:05
d493fe5 to
6567501ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
June 23, 2026 17:13
6567501 to
d55c71aComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
June 25, 2026 16:14
d55c71a to
1741c26ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
2 times, most recently
from
July 9, 2026 10:51
d2a0efb to
437f49fComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
2 times, most recently
from
July 25, 2026 06:14
f5216a0 to
0550a75ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
July 28, 2026 14:03
0550a75 to
297e58cComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
2 times, most recently
from
August 12, 2026 01:15
44e0d51 to
7850f03ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
4 times, most recently
from
August 18, 2026 13:16
a6711d7 to
9f7aca2ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
August 21, 2026 14:08
9f7aca2 to
335a9a7ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
August 26, 2026 13:08
335a9a7 to
505fcd7ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
3 times, most recently
from
September 4, 2026 13:51
f9b5345 to
9e50602ComparerenovateBotforce-pushed
the
renovate/major-puppeteer
branch
from
September 7, 2026 17:44
9e50602 to
e68779aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^24.43.1→^25.10.0Release Notes
puppeteer/puppeteer (puppeteer)
v25.10.0: puppeteer: v25.10.0Compare Source
♻️ Chores
Dependencies
v25.9.0: puppeteer: v25.9.0Compare Source
♻️ Chores
Dependencies
v25.8.0Compare Source
🎉 Features
🛠️ Fixes
Dependencies
v25.7.0Compare Source
🎉 Features
Dependencies
🛠️ Fixes
🏗️ Refactor
v25.6.0Compare Source
♻️ Chores
Dependencies
🎉 Features
🛠️ Fixes
🏗️ Refactor
v25.5.0Compare Source
♻️ Chores
Dependencies
🎉 Features
🛠️ Fixes
📄 Documentation
🏗️ Refactor
v25.4.0Compare Source
🎉 Features
using) (#15027) (a1ca86b)Dependencies
🛠️ Fixes
v25.3.0Compare Source
♻️ Chores
Dependencies
🎉 Features
🛠️ Fixes
📄 Documentation
v25.2.1Compare Source
♻️ Chores
Dependencies
🛠️ Fixes
v25.2.0Compare Source
🎉 Features
🛠️ Fixes
Dependencies
📄 Documentation
⚡ Performance
headersArrayiteration in HTTPRequest (#15004) (eb95798)🏗️ Refactor
v25.1.0Compare Source
🎉 Features
🛠️ Fixes
🏗️ Refactor
Dependencies
📄 Documentation
v25.0.4Compare Source
♻️ Chores
Dependencies
🛠️ Fixes
v25.0.3Compare Source
♻️ Chores
Dependencies
🛠️ Fixes
v25.0.2Compare Source
♻️ Chores
Dependencies
🛠️ Fixes
Configuration
📅 Schedule: (in timezone Asia/Shanghai)
* 0-3 1,15 * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.