fix(pnpm): install don't take a list of packages - #1009
Merged
Merged
Conversation
aeppling
approved these changes
Apr 11, 2026
Contributor
|
Hey @KuSh Need to solve conflicts then ready for merge |
Collaborator
Author
|
done @aeppling! |
Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
KuSh
force-pushed
the
broken-pnpm-i
branch
2 times, most recently
from
April 11, 2026 15:33
4fdfdfe to
9a50efa
Compare
aeppling
approved these changes
May 3, 2026
Contributor
|
Hey @KuSh LGTM ! Thanks for the patience for review, had a lot of work beside :) |
Merged
thehoff
pushed a commit
to thehoff/contextcrawler
that referenced
this pull request
May 14, 2026
fix(pnpm): install don't take a list of packages
thehoff
pushed a commit
to thehoff/contextcrawler
that referenced
this pull request
May 14, 2026
fix(pnpm): install don't take a list of packages
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove packages handling for pnpm install command.
While testing another PR, I stumbled across this error:
Upon checking pnpm documentation, it turns out that pnpm install doesn't take a list of packages.
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected