Skip to content

fix(pnpm): install don't take a list of packages - #1009

Merged
aeppling merged 1 commit into
rtk-ai:developfrom
KuSh:broken-pnpm-i
May 3, 2026
Merged

aeppling merged 1 commit into
rtk-ai:developfrom
KuSh:broken-pnpm-i

Conversation

@KuSh

@KuSh KuSh commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove packages handling for pnpm install command.

While testing another PR, I stumbled across this error:

$ cargo run -- pnpm install -h
thread 'main' (239705) panicked at ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.60/src/builder/debug_asserts.rs:570:9:
Positional argument `[ARGS]...` *must* have `required(true)` or `last(true)` set because a prior positional argument (`[PACKAGES]...`) has `num_args(1..)`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Upon checking pnpm documentation, it turns out that pnpm install doesn't take a list of packages.

Test plan

  • cargo fmt --all && cargo clippy --all-targets && cargo test
  • Manual testing: rtk <command> output inspected

@aeppling

Copy link
Copy Markdown
Contributor

Hey @KuSh

Need to solve conflicts then ready for merge

@aeppling aeppling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts

@KuSh
KuSh requested a review from aeppling April 11, 2026 14:33
@KuSh

KuSh commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator Author

done @aeppling!

Signed-off-by: Nicolas Le Cam <niko.lecam@gmail.com>
@KuSh
KuSh force-pushed the broken-pnpm-i branch 2 times, most recently from 4fdfdfe to 9a50efa Compare April 11, 2026 15:33
@aeppling

aeppling commented May 3, 2026

Copy link
Copy Markdown
Contributor

Hey @KuSh

LGTM !

Thanks for the patience for review, had a lot of work beside :)

@aeppling
aeppling merged commit 492aa76 into rtk-ai:develop May 3, 2026
10 checks passed
@aeppling aeppling mentioned this pull request May 3, 2026
@KuSh
KuSh deleted the broken-pnpm-i branch May 3, 2026 16:01
thehoff pushed a commit to thehoff/contextcrawler that referenced this pull request May 14, 2026
fix(pnpm): install don't take a list of packages
thehoff pushed a commit to thehoff/contextcrawler that referenced this pull request May 14, 2026
fix(pnpm): install don't take a list of packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants