fix(find): accept native find flags (-name, -type, etc.)

[sahilmgandhi]

Summary

• rtk find . -name "*.rs" -type f fails with unexpected argument '-n' found because Clap decomposes -name into short flags (-n, -a, -m, -e) and -n is not defined
• Changed Find to use trailing_var_arg = true, allow_hyphen_values = true (consistent with Grep, Ls, Tree, and most other RTK commands)
• Added parse_find_args() that detects and handles both native find syntax (-name, -type, -maxdepth, -iname) and existing RTK syntax (rtk find *.rs src -m 50 -t f)
• Rejects unsupported compound predicates (-not, -exec, -delete, etc.) with a clear error instead of silently giving wrong results

Changes

File	Change
src/main.rs	Replaced named Find args with trailing_var_arg + dispatch to run_from_args()
src/find_cmd.rs	Added parse_find_args() with native/RTK syntax detection, FindArgs with Default, next_arg helper. Fixed -maxdepth to wire to WalkBuilder::max_depth (traversal depth, not display limit). -iname now performs case-insensitive glob matching. Unsupported flags (-not, -exec, etc.) bail with clear error. 15 new tests.

Test plan

• cargo fmt --all passes
• cargo clippy --all-targets clean
• cargo test find_cmd — 27/27 tests pass (15 new)
• cargo test --all — 409/409 tests pass
• Manual test: rtk find . -name "*.rs" -type f — works, returns compact output

📁 58F 4D:

src/ cargo_cmd.rs cc_economics.rs ccusage.rs config.rs container.rs curl_cmd.rs deps.rs diff_cmd.rs display_helpers.rs env_cmd.rs filter.rs find_cmd.rs format_cmd.rs gain.rs gh_cmd.rs git.rs go_cmd.rs golangci_cmd.rs grep_cmd.rs hook_audit_cmd.rs init.rs json_cmd.rs lint_cmd.rs local_llm.rs log_cmd.rs ls.rs main.rs next_cmd.rs npm_cmd.rs pip_cmd.rs playwright_cmd.rs pnpm_cmd.rs prettier_cmd.rs prisma_cmd.rs pytest_cmd.rs read.rs ruff_cmd.rs runner.rs summary.rs tee.rs tracking.rs tree.rs tsc_cmd.rs utils.rs vitest_cmd.rs wc_cmd.rs wget_cmd.rs
src/discover/ mod.rs provider.rs registry.rs

[pszymkowiak]

Nice work! Clean approach, consistent with how we handle git.rs and grep_cmd.rs (trailing_var_arg + manual parsing). Auto-detection of native vs RTK syntax is smart.

15 new tests, security is fine (-exec properly rejected), -iname and -maxdepth are good additions.

One thing to fix before merge:

In parse_native_find_args(), unknown flags are silently swallowed by the _ => {} catch-all. This means rtk find . -mindepth 2 -name "*.rs" succeeds but ignores -mindepth — the user thinks it works but gets wrong results.

Please add a warning on stderr for unknown flags:

_ => {
    eprintln!("rtk find: unknown flag '{}', ignored", args[i]);
}

This way users know their flag was dropped instead of getting silently wrong results.

Everything else looks good — small fix and we can merge 👍

[pszymkowiak]

Thanks for this PR! Clean approach, consistent with how we handle git.rs and grep_cmd.rs (trailing_var_arg + manual parsing). Auto-detection of native vs RTK syntax is smart.

Tests are solid (15 new), security is fine (-exec properly rejected), and -iname / -maxdepth are nice additions.

One thing to fix before merge: in parse_native_find_args(), unknown flags are silently swallowed by the _ => {} catch-all. I tested with -mindepth and it succeeds without warning — the
user thinks it works but gets wrong results.

_ => {
eprintln!("rtk find: unknown flag '{}', ignored", args[i]);
}

Small fix and we can merge — thanks again!

[sahilmgandhi]

Thank you for the review @pszymkowiak, I took a pass at it, and updated the PR accordingly.

[aros3rg3d]

Thanks! It close #170 as well :)

[pszymkowiak]

Review: PR #211

The find implementation is solid — auto-detection of native vs RTK syntax, clear rejection of unsupported flags (-not, -exec, etc.), and good test coverage (27 tests).

Local testing confirmed everything works:

• rtk find . -name "*.rs" -type f — correct, 58 files grouped by directory
• rtk find "*.toml" — RTK syntax works
• rtk find . -iname "cargo.toml" — case-insensitive works
• rtk find . -name "*.rs" -maxdepth 1 — depth limiting works
• rtk find . -not -name "*test*" — correctly rejected with clear error message
• rtk find . -exec rm {} \; — correctly rejected

One issue: the branch needs a rebase on current master (ab5dbb1). The diff shows deletions in gh_cmd.rs, git.rs, grep_cmd.rs, playwright_cmd.rs and main.rs that are just missing upstream additions (markdown filter, rtk wc, grep -n flag, etc.). The find code itself is clean — only find_cmd.rs and its routing in main.rs should change.

Fix: git rebase master and resolve conflicts keeping upstream changes. After that, this is ready to merge.

[sahilmgandhi]

Thanks, I rebased to master and fixed the diffs to keep only the changed files.

[pszymkowiak]

Re-tested locally after rebase — all clean.

• 446/446 tests pass (27 find-specific)
• Native syntax works: find . -name "*.rs" -type f, -maxdepth, -iname
• Unsupported flags properly rejected: -not, -exec → clear error message
• Unknown flags warned: -mindepth → rtk find: unknown flag '-mindepth', ignored
• RTK syntax still works: find "*.toml" → backwards compatible
• Diff is clean — only find_cmd.rs, main.rs + minor cargo fmt in 2 files

All previous review items addressed. LGTM, ready to merge.

[sahilmgandhi]

Thanks @pszymkowiak , you marked the PR as DONE_REVIEW, is there a workflow that picks this up to make the PR mergeable? I am unable to merge it right now:

[reneleonhardt]

What would be needed to make compound predicates possible?

$ rtk find ../parallel-project -type f \( -name "*.swift" -o -name "*.plist" -o -name "*.entitlements" -o -name "Package.swift" \) | head -50
rtk: rtk find does not support compound predicates or actions (e.g. -not, -exec). Use `find` directly.