Skip to content

feat: add support for yarn test (Vitest) - #272

Closed
dlmw wants to merge 1 commit into
rtk-ai:masterfrom
dlmw:feature/yarn-test
Closed

dlmw wants to merge 1 commit into
rtk-ai:masterfrom
dlmw:feature/yarn-test

Conversation

@dlmw

@dlmw dlmw commented Feb 27, 2026

Copy link
Copy Markdown

No description provided.

@pszymkowiak

Copy link
Copy Markdown
Collaborator

Hi, this PR has conflicts with master. Could you rebase on current master? Thanks!

@dlmw
dlmw force-pushed the feature/yarn-test branch from 4c89ed1 to 3dc89a3 Compare March 2, 2026 15:00
@dlmw

dlmw commented Mar 2, 2026

Copy link
Copy Markdown
Author

Should be good now. Could you run the workflows, please?

@dlmw
dlmw force-pushed the feature/yarn-test branch from 3dc89a3 to c4379db Compare March 3, 2026 14:00
@aeppling

aeppling commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Hello, this is valid but we're going to merge and release #241
which will change how you insert your rewrite cmd.

This will be available during this week.

I will notify you for this little change so we have no conflict then.

@aeppling aeppling added depends-on depends on another PR or awaiting changes labels Mar 3, 2026
@FlorianBruniaux

Copy link
Copy Markdown
Contributor

Hi @ThomasHoussin, @dlmw, @denneulin! You've each opened yarn-related PRs (#317, #272, #226) that all create yarn_cmd.rs — they'll conflict with each other. Could you coordinate? @ThomasHoussin's #317 is the most comprehensive, so we're thinking of using it as the base. @dlmw, @denneulin — could you check if your specific additions (vitest support, workspace support) could be contributed to #317 instead, or if #317 already covers them?

@pszymkowiak

Copy link
Copy Markdown
Collaborator

Note: this PR adds rules to hooks/rtk-rewrite.sh, but since #241 (rtk rewrite), all rewrite logic lives in Rust (src/discover/rules.rs + src/discover/registry.rs). The bash hook now just calls rtk rewrite "$cmd".

Please remove the changes to rtk-rewrite.sh and add your yarn test patterns to rules.rs / registry.rs instead.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak

Copy link
Copy Markdown
Collaborator

Hi! Two things needed before we can review:

  1. Retarget to develop — this PR targets master, but all PRs should target develop. You can change the base branch in the PR settings (right sidebar).
  2. Sign the CLA — if not already done, please sign at https://cla-assistant.io/rtk-ai/rtk

Thanks!

@aeppling

Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

@ThomasHoussin

Copy link
Copy Markdown

I rebased #317, which I think covers #226 and #272. I think we could close both #226 and #272 and adjust #317 if necessary.

@pszymkowiak

Copy link
Copy Markdown
Collaborator

Hi @dlmw — closing as superseded by #317, per @FlorianBruniaux's
2026-03-05 coordination note (three overlapping yarn PRs — #317 chosen
as the base) and @ThomasHoussin's 2026-03-30 follow-up explicitly
asking to close both #226 and #272 in favor of his consolidated branch.

A few things have also moved since this PR was opened that would
require a substantial rebase:

Your yarn test (Vitest) routing pattern was the kind of thing
#317 picked up — thanks for raising the test case. If you want to
follow the merge, #317 is the active thread.

Closing as superseded by #317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends-on depends on another PR or awaiting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants