Skip to content

fix(build): increase Windows startup stack - #865

Merged
FlorianBruniaux merged 1 commit into
rtk-ai:developfrom
timeshift92:fix/windows-startup-stack-849
Mar 28, 2026
Merged

FlorianBruniaux merged 1 commit into
rtk-ai:developfrom
timeshift92:fix/windows-startup-stack-849

Conversation

@timeshift92

Copy link
Copy Markdown

Summary

Test plan

  • cargo fmt --all && cargo clippy --all-targets && cargo test
  • Manual testing: rtk <command> output inspected

Important: All PRs must target the develop branch (not master).
See CONTRIBUTING.md for details.

Signed-off-by: Ахмедов Нурбек Медетбаевич <n.akhmedov@uzdc.uz>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ахмедов Нурбек Медетбаевич seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aeppling

Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

@FlorianBruniaux
FlorianBruniaux merged commit fb35e23 into rtk-ai:develop Mar 28, 2026
1 of 2 checks passed
thehoff pushed a commit to thehoff/contextcrawler that referenced this pull request May 14, 2026
…ack-849

LGTM. Correct fix — Clap's command graph can overflow the default 1MB Windows stack. /STACK:8388608 is a standard mitigation.
thehoff pushed a commit to thehoff/contextcrawler that referenced this pull request May 14, 2026
…ack-849

LGTM. Correct fix — Clap's command graph can overflow the default 1MB Windows stack. /STACK:8388608 is a standard mitigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants