Uh oh!
There was an error while loading. Please reload this page.
Fix checkbox and radio button contrast for dark mode - #324
Merged
Conversation
Fixes#320. The contrast for the "check" and the background in dark mode was not enough, making it seem like the checkbox was uncheckable.
| }, | ||
| class: [ | ||
| "peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background accent-primary", | ||
| "peer h-4 w-4 shrink-0 rounded-sm border-input ring-offset-background accent-primary", |
ContributorAuthor
There was a problem hiding this comment.
This is the default.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#320
This is a continuation of #323 from @ianmurrays.
This Pull request fixes both the checkbox and the radio button styles when in a dark mode.
Important note: Shadcn changes the DOM implementation of the checkbox using a button and another element for the indicator. In our case, we rely on the checkbox with a
background-imagedefault from tailwind. This limits us to usebackground-colorandcolortogether like shadcn does.