Skip to content

Add checked:bg-primary to combobox_toggle_all_checkbox - #327

Merged
djalmaaraujo merged 2 commits into
ruby-ui:mainfrom
pierry01:jean/fix-checkbox-combobox
Dec 17, 2025
Merged

Add checked:bg-primary to combobox_toggle_all_checkbox#327
djalmaaraujo merged 2 commits into
ruby-ui:mainfrom
pierry01:jean/fix-checkbox-combobox

Conversation

@pierry01

Copy link
Copy Markdown
Contributor

BEFORE

Image

AFTER

Image

@pierry01
pierry01 requested a review from cirdes as a code ownerDecember 9, 2025 21:22

@pierry01pierry01Dec 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's basically equal to combobox_checkbox

@djalmaaraujodjalmaaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierry01 Can you update the pull request description with a proper before/after? Also, inform the purpose of this change? The screenshots failed to load. Thank you!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds checked state styling to the combobox toggle all checkbox component to ensure visual consistency when the checkbox is selected. The addition of checked:bg-primary and checked:text-primary-foreground classes aligns this component with other checkbox components in the codebase.

Key Changes:

  • Added checked:bg-primary checked:text-primary-foreground classes to provide proper styling for the checked state
  • Reordered CSS classes to group related styling concerns together (disabled, checked, aria-disabled, focus-visible)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djalmaaraujodjalmaaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@djalmaaraujo
djalmaaraujo merged commit 705e374 into ruby-ui:mainDec 17, 2025
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pierry01@djalmaaraujo