Skip to content

Add config option to skip confirmation on quit#525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hugovandevliert wants to merge 2 commits into from
Closed

Add config option to skip confirmation on quit #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba6a31e
Add RUBY_DEBUG_NO_CONFIRM_QUIT config option
hugovandevliert Feb 5, 2022
c288a7a
Add test case for new config option
hugovandevliert Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -470,6 +470,7 @@ config set no_color true
* `RUBY_DEBUG_POSTMORTEM` (`postmortem`): Enable postmortem debug (default: false)
* `RUBY_DEBUG_FORK_MODE` (`fork_mode`): Control which process activates a debugger after fork (both/parent/child) (default: both)
* `RUBY_DEBUG_SIGDUMP_SIG` (`sigdump_sig`): Sigdump signal (default: disabled)
* `RUBY_DEBUG_NO_CONFIRM_QUIT` (`no_confirm_quit`): Do not ask for confirmation on q[uit] or Crtl-D (default: false)

* BOOT
* `RUBY_DEBUG_NONSTOP` (`nonstop`): Nonstop mode
Expand Down
1 change: 1 addition & 0 deletions lib/debug/config.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ module DEBUGGER__
postmortem: ['RUBY_DEBUG_POSTMORTEM', "CONTROL: Enable postmortem debug (default: false)", :bool],
fork_mode: ['RUBY_DEBUG_FORK_MODE', "CONTROL: Control which process activates a debugger after fork (both/parent/child) (default: both)", :forkmode],
sigdump_sig: ['RUBY_DEBUG_SIGDUMP_SIG', "CONTROL: Sigdump signal (default: disabled)"],
no_confirm_quit:['RUBY_DEBUG_NO_CONFIRM_QUIT',"CONTROL: Do not ask for confirmation on q[uit] or Crtl-D (default: false)", :bool],

# boot setting
nonstop: ['RUBY_DEBUG_NONSTOP', "BOOT: Nonstop mode", :bool],
Expand Down
2 changes: 1 addition & 1 deletion lib/debug/session.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -444,7 +444,7 @@ def process_command line
# * `q[uit]` or `Ctrl-D`
# * Finish debugger (with the debuggee process on non-remote debugging).
when 'q', 'quit'
if ask 'Really quit?'
if CONFIG[:no_confirm_quit] || ask('Really quit?')
@ui.quit arg.to_i
leave_subsession :continue
else
Expand Down
7 changes: 7 additions & 0 deletions test/debug/quit_test.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,13 @@ def test_quit_does_not_quit_debugger_process_if_not_confirmed
end
end

def test_quit_quits_immediately_if_no_confirm_quit_is_set_to_true
debug_code(program) do
type 'config set no_confirm_quit true'
type 'q'
end
end
Comment on lines +30 to +35

@hugovandevlierthugovandevliertFeb 11, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spec doesn't pass. I suspect it's because of test/tool/test_builder.rb:121, but I'm not sure. If the maintainers are interested in this PR I'll happily spend some time trying to make this spec pass.


def test_quit_with_exclamation_mark_quits_immediately_debugger_process
debug_code(program) do
type 'q!'
Expand Down