Don't stop at DAP's connection

[st0012]

Based on the discussion in #629, DAP's connection stoppage can be removed.

Closes#629

[ko1]

I found two lines comment outs are needed to "non-stop" with VSCode attach mode.
Is it intentional or the following patch is your favorite in the scenario on #629 (I guess so)?

diff --git a/lib/debug/server.rb b/lib/debug/server.rb
index 9abb187..abd3752 100644
--- a/lib/debug/server.rb+++ b/lib/debug/server.rb@@ -68,7 +68,7 @@ module DEBUGGER__
} unless already_connected
setup_interrupt do
- pause unless already_connected+ # pause unless already_connected
process
end
diff --git a/lib/debug/server_dap.rb b/lib/debug/server_dap.rb
index 84f954d..0842784 100644
--- a/lib/debug/server_dap.rb+++ b/lib/debug/server_dap.rb@@ -256,7 +256,7 @@ module DEBUGGER__
UI_DAP.local_fs_map_set req.dig('arguments', 'localfs') || req.dig('arguments', 'localfsMap')
when 'attach'
send_response req
- Process.kill(UI_ServerBase::TRAP_SIGNAL, Process.pid)+ # Process.kill(UI_ServerBase::TRAP_SIGNAL, Process.pid)
@is_attach = true
UI_DAP.local_fs_map_set req.dig('arguments', 'localfs') || req.dig('arguments', 'localfsMap')
when 'setBreakpoints'

[st0012]

@ko1 Yes, thanks for catching it. I've updated the server_dap part as well.

[st0012]

I think the current code works: DAP connection will not stop at connection, but CUI connection will still stop.
However, after skipping the initial stop, the terminating disconnect request doesn't work anymore:

To reproduce:

1. Start a Rails server with rdbg -O -n -c -- bundle exec rails
2. Attach to it from VSCode
3. Click the disconnect dropdown and click Stop

With Stop (master)

#53409:[>] {"command":"disconnect","arguments":{"restart":false,"terminateDebuggee":true},"type":"request","seq":15}
#53409:[<] {"type":"response","command":"disconnect","request_seq":15,"success":true,"message":"Success","seq":18}
# Debuggee exits

Without Stop (this branch)

#52510:[>] {"command":"disconnect","arguments":{"restart":false,"terminateDebuggee":true},"type":"request","seq":10}
#52510:[<] {"type":"response","command":"disconnect","request_seq":10,"success":true,"message":"Success","seq":11}
#52510:[<] {"type":"event","event":"terminated","seq":12}
DEBUGGER: Disconnected.
# Debuggee doesn't exit

It looks like without the initial stop, this kill! command won't be processed:

debug/lib/debug/server_dap.rb

Line 318 in 49ac0a1

@q_msg << 'kill!'

[st0012]

Ah it's because commands will only be processed when suspended.

[ko1]

fixed by #688