Skip to content

Protocol test framework improvements - #654

Merged
peterzhu2118 merged 4 commits into
ruby:masterfrom
st0012:fix-protocol-test
Jun 24, 2022
Merged

Protocol test framework improvements#654
peterzhu2118 merged 4 commits into
ruby:masterfrom
st0012:fix-protocol-test

Conversation

@st0012

@st0012st0012 commented Jun 11, 2022

Copy link
Copy Markdown
Member

I made these changes when debugging Ruby head's hanging issue and they did make the build failures easier to catch.

  1. Both debuggee connection and workflows should have timeout
  2. Rename WebSocketClient#cleanup to #close because that's all it does
  3. Only perform cleanup logic when the socket/threads are present, which may not be the case when the error happens during test setup.

@st0012
st0012force-pushed the fix-protocol-test branch 23 times, most recently from a105e13 to dbfaee9CompareJune 13, 2022 21:22
@st0012st0012 changed the title Add timeout to remote debuggee waiting logicTest improvementsJun 13, 2022
@st0012
st0012force-pushed the fix-protocol-test branch from dbfaee9 to 0c2234bCompareJune 13, 2022 22:03
@st0012
st0012 marked this pull request as ready for review June 13, 2022 23:09
st0012 added 4 commits June 24, 2022 21:04
The default timeout is 6 hours, which is unnecessarily long. We should
stop tests if it doesn't finish in 10~15 mins to see what happens.
@st0012
st0012force-pushed the fix-protocol-test branch from 0c2234b to ab55aafCompareJune 24, 2022 20:04
@st0012st0012 changed the title Test improvementsProtocol test framework improvementsJun 24, 2022
@st0012

Copy link
Copy Markdown
MemberAuthor

@peterzhu2118 I could also use your help on this test improvement. You can run protocol tests with bundle exec rake test_protocol, which is not included in rake test.

@peterzhu2118peterzhu2118 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@peterzhu2118
peterzhu2118 merged commit 0e60ff3 into ruby:masterJun 24, 2022
@st0012
st0012 deleted the fix-protocol-test branch June 24, 2022 20:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012@peterzhu2118