Uh oh!
There was an error while loading. Please reload this page.
Enable "step back <n>" while replay - #754
Merged
Merged
Conversation
ono-max
marked this pull request as draft
October 18, 2022 10:48
ono-maxforce-pushed
the
patch-6
branch
4 times, most recently
from
October 18, 2022 11:57
cf84579 to
915aabdCompareono-max
marked this pull request as ready for review
October 18, 2022 12:05
ono-max
commented
Oct 18, 2022
| def step_back iter | ||
| @index += iter | ||
| if @index > @log.size | ||
| @index = @log.size |
MemberAuthor
There was a problem hiding this comment.
When n of "step back " is larger than current @index, @index will be size of log.
ko1
reviewed
Oct 25, 2022
| leave_subsession [:step, type, arg&.to_i] | ||
| end | ||
| when /\Aback\z/, /\Areset\z/ | ||
| when /\A(back)\z/, /\A(reset)\z/, /\A(back)\s(\d+)\z/ |
ko1
reviewed
Oct 25, 2022
| leave_subsession [:step, type, arg&.to_i] | ||
| end | ||
| when /\Aback\z/, /\Areset\z/ | ||
| when /\A(back)\z/, /\A(reset)\z/, /\A(back)\s(\d+)\z/ |
Collaborator
There was a problem hiding this comment.
Suggested change
| when/\A(back)\z/,/\A(reset)\z/,/\A(back)\s(\d+)\z/ | |
| when/\A(back)\z/,/\A(back)\s+(\d+)\z/,/\A(reset)\z/ |
ko1
reviewed
Oct 25, 2022
| else | ||
| request_tc [:step, arg.to_sym] | ||
| type = $1.to_sym | ||
| iter = $2.to_i unless $2.nil? |
Collaborator
There was a problem hiding this comment.
Suggested change
| iter= $2.to_iunless $2.nil? | |
| iter= $2&.to_i |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
step back <n>doesn't work in replay mode. This PR fixes it.