Uh oh!
There was an error while loading. Please reload this page.
Move digest.rb back under ext as the extension bundled library - #23
Merged
Conversation
nobuforce-pushed
the
move-digest.rb-back
branch
from
September 7, 2021 04:44
1f26e14 to
026ba7fCompareknu
commented
Sep 7, 2021
Member
You should have waited for #20 before doing this because it causes a conflict. |
hsbt
commented
Sep 7, 2021
Member
And I'm not sure why we leave from the standard gem layout with this changes. |
knu
commented
Sep 7, 2021
Member
My plan is to have platform independent parts in lib/digest.rb and platform specific parts in ext, one for CRuby and another for JRuby. |
hsbt
commented
Sep 7, 2021
Member
@knu I agreed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.