Uh oh!
There was an error while loading. Please reload this page.
add regex for bool parsing & test struct w/ bool parsing - #169
Merged
Conversation
kou
approved these changes
Jan 6, 2025
kou
left a comment
Member
There was a problem hiding this comment.
Could you explain what is the problem and how to solve it in the PR description?
We'll use the PR description for commit message.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
wallacerunner
commented
Jan 10, 2025
ContributorAuthor
Now that I gave it some thought, shouldn't this be the other way around? I.e. isn't parse_struct supposed to invoke parse_ctype on just the type definition, and not parse_ctype running regexp on given string? |
kou
commented
Jan 10, 2025
Member
We can revisit it as a separated task. |
hsbt pushed a commit
to hsbt/ruby
that referenced
this pull request
Jan 14, 2025
parsing (ruby/fiddle#169) GitHub: fixruby/fiddle#168 Struct parsing invokes "parse_ctype" on the whole member signature, which fails if member type is "bool" due to plain string matching for it. This change updates "bool" type matching to a regexp, so TYPE_BOOL is correctly parsed for a whole signature like "bool toggle" as well as just "bool". --------- ruby/fiddle@71607446d4 Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
hsbt pushed a commit
to hsbt/ruby
that referenced
this pull request
Jan 14, 2025
parsing (ruby/fiddle#169) GitHub: fixruby/fiddle#168 Struct parsing invokes "parse_ctype" on the whole member signature, which fails if member type is "bool" due to plain string matching for it. This change updates "bool" type matching to a regexp, so TYPE_BOOL is correctly parsed for a whole signature like "bool toggle" as well as just "bool". --------- ruby/fiddle@71607446d4 Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
hsbt pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 14, 2025
parsing (ruby/fiddle#169) GitHub: fixruby/fiddle#168 Struct parsing invokes "parse_ctype" on the whole member signature, which fails if member type is "bool" due to plain string matching for it. This change updates "bool" type matching to a regexp, so TYPE_BOOL is correctly parsed for a whole signature like "bool toggle" as well as just "bool". --------- ruby/fiddle@71607446d4 Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub: fixGH-168
Struct parsing invokes "parse_ctype" on the whole member signature, which fails if member type is "bool" due to plain string matching for it. This change updates "bool" type matching to a regexp, so TYPE_BOOL is correctly parsed for a whole signature like "bool toggle" as well as just "bool".