Skip to content

Fix memory corruption with FFI backend#180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Apr 21, 2025
+2 −2
Merged

Fix memory corruption with FFI backend #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae9b0bb
Fix memory corruption with FFI backend
ankane Apr 21, 2025
ce19331
Fix to_s reading past size
ankane Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/fiddle/ffi_backend.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -240,7 +240,7 @@ def self.from_native(value, ctx)
def self.to_ptr(value)
if value.is_a?(String)
cptr = Pointer.malloc(value.bytesize)
cptr.ffi_ptr.put_string(0, value)
cptr.ffi_ptr.put_bytes(0, value)
cptr

elsif value.is_a?(Array)
Expand DownExpand Up@@ -412,7 +412,7 @@ def to_s(len = nil)
if len
ffi_ptr.read_string(len)
else
ffi_ptr.get_string(0)
ffi_ptr.get_string(0, @size)
end
rescue FFI::NullPointerError
raise DLError.new("NULL pointer access")
Expand Down