Uh oh!
There was an error while loading. Please reload this page.
Add Fiddle::MemoryView.available? - #208
Merged
Merged
Conversation
kou
approved these changes
Jul 24, 2026
Comment on lines
+34
to
+36
| assert_equal(true, MemoryView.available?(Pointer["hello world"])) | ||
| assert_equal(false, MemoryView.available?(Fiddle::NULL)) | ||
| assert_equal(false, MemoryView.available?(Object.new)) |
Member
There was a problem hiding this comment.
Could you use power assert style for better message on failure?
Suggested change
| assert_equal(true,MemoryView.available?(Pointer["hello world"])) | |
| assert_equal(false,MemoryView.available?(Fiddle::NULL)) | |
| assert_equal(false,MemoryView.available?(Object.new)) | |
| assert{MemoryView.available?(Pointer["hello world"])} | |
| assert{!MemoryView.available?(Fiddle::NULL)} | |
| assert{!MemoryView.available?(Object.new)} |
Fiddle had no binding for `rb_memory_view_available_p()`, which callers can use to check whether an object supports the memory view protocol.
himura467force-pushed
the
memory-view-available-p
branch
from
July 24, 2026 04:01
a166934 to
cff7d57CompareUh oh!
There was an error while loading. Please reload this page.
kou
commented
Jul 24, 2026
Member
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiddle had no binding for
rb_memory_view_available_p(), which callers can use to check whether an object supports the memory view protocol.