Modernize `GetoptLong#get` - #22

Open

RuhmUndAnsehen wants to merge 20 commits into

ruby:masterfrom

RuhmUndAnsehen:modernize_get

Commits on Nov 4, 2025

Don't mess with global constants directly.
RuhmUndAnsehen
committed
7859c5b
Add tests for previously untested code paths.
RuhmUndAnsehen
committed
55cd739
Add tests for the long option assignment case.
RuhmUndAnsehen
committed
2e751e4
Sanity checking `@rest_singles` early makes control and data flow easier to track.
RuhmUndAnsehen
committed
456a433
Simplify terminate conditions.
RuhmUndAnsehen
committed
51548a7
Simplify the branches setting local variable `argument`.
RuhmUndAnsehen
committed
ded7bf8
Use pattern matching for option processing.
RuhmUndAnsehen
committed
7fe99a1
Remove redundant conditional branch for long options.
RuhmUndAnsehen
committed
c5ab511
Shorten and simplify the short style option processing.
RuhmUndAnsehen
committed
ebcebba
Move the _end of ARGV_ termination code into a case pattern
RuhmUndAnsehen
committed
c1253d3
Cleanup the conditions for ARGV shifting.
RuhmUndAnsehen
committed
df20da2
Simplify option abbreviation matcher.
RuhmUndAnsehen
committed
36ea888
Switch the conditional branches for short style options.
RuhmUndAnsehen
committed
ada6998
Rename capture groups so they are identical for both long and short options.
RuhmUndAnsehen
committed
d6c5992
Collapse the conditional branches for long and short options into one.
RuhmUndAnsehen
committed
cc09763
Shorten control flow and improve readability.
RuhmUndAnsehen
committed
bba752c
Improve control flow of @rest_singles handling.
RuhmUndAnsehen
committed
465177f
Control flow: now all pattern branches return. Removed redundant line.
RuhmUndAnsehen
committed
72f8de7
Fixed comments.
RuhmUndAnsehen
committed
56b7023
Added a bunch of `raise_...` methods to improve readability.
RuhmUndAnsehen
committed
cafe800

Navigation Menu

Uh oh!

Modernize `GetoptLong#get` - #22

Modernize `GetoptLong#get`#22
RuhmUndAnsehen wants to merge 20 commits into
ruby:masterfrom
RuhmUndAnsehen:modernize_get

Commits on Nov 4, 2025

Don't mess with global constants directly.

Add tests for previously untested code paths.

Add tests for the long option assignment case.

Sanity checking `@rest_singles` early makes control and data flow easier to track.

Simplify terminate conditions.

Simplify the branches setting local variable `argument`.

Use pattern matching for option processing.

Remove redundant conditional branch for long options.

Shorten and simplify the short style option processing.

Move the _end of ARGV_ termination code into a case pattern

Cleanup the conditions for ARGV shifting.

Simplify option abbreviation matcher.

Switch the conditional branches for short style options.

Rename capture groups so they are identical for both long and short options.

Collapse the conditional branches for long and short options into one.

Shorten control flow and improve readability.

Improve control flow of @rest_singles handling.

Control flow: now all pattern branches return. Removed redundant line.

Fixed comments.

Added a bunch of `raise_...` methods to improve readability.