Skip to content

Avoid timing race in noecho test #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobu merged 3 commits into from
Aug 11, 2026
Merged

Avoid timing race in noecho test #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba11798
Define "rdoc:coverage" task for old RDoc
nobu Aug 11, 2026
60215ae
Define the backend specific test only for the backend
nobu Aug 11, 2026
664fbc6
Avoid timing race in `noecho` test
nobu Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Rakefile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,9 @@ task "build" => %w[rdoc:coverage build:java]

task "build:java" => "date_epoch"

# For old the RDoc included with Ruby 2.6, which doesn't define this task.
task "rdoc:coverage"

# Keep RDoc::Task's coverage check from exiting the Rake process.
coverage_task = Rake::Task["rdoc:coverage"].actions.shift
task "rdoc:coverage" do |*t|
Expand Down
7 changes: 3 additions & 4 deletions test/io/console/test_io_console.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -211,7 +211,8 @@ def test_noecho
s.noecho {
assert_not_send([s, :echo?])
m.print "a"
sleep 0.1
m.flush
assert_equal("a", s.getch)
}
m.print "b"
assert_equal("b", m.readpartial(10))
Expand DownExpand Up@@ -309,8 +310,6 @@ def test_console_mode
end

def test_stty_redirect_stdout
omit unless IO.private_method_defined?(:_io_console_stty)

helper do |_, s|
stdout = STDOUT.dup
begin
Expand All@@ -322,7 +321,7 @@ def test_stty_redirect_stdout
end
assert_not_empty(mode)
end
end
end if IO.private_method_defined?(:_io_console_stty)

def test_tty_on_pty
pend "not supported" unless TTY_ENHANCED
Expand Down
Loading