Uh oh!
There was an error while loading. Please reload this page.
JRuby support - #2
Conversation
headius
commented
Sep 24, 2021
I have no idea why the JRuby jobs are stuck. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
headius
commented
Nov 29, 2021
I have pushed the missing bits for JRuby and rebased on current master. Additional changes from previous review:
This addresses both of @ahorek's review comments. I also tested that the built gem can install and replace the builtin io/wait in JRuby. So it is pretty close now. |
Uh oh!
There was an error while loading. Please reload this page.
headius
commented
Nov 30, 2021
Something is still not right with the JRuby builds. |
olleolleolle
commented
Nov 30, 2021
is it missing a |
There are no dependencies for CRuby (dev or otherwise) so no bundling is done in any of the builds. I will add the necessary bits for JRuby. |
headius
commented
Nov 30, 2021
Looks like we have a winner! This can be squashed during merge, or if preferred I can rewrite the commits to better reflect the changes I made. |
headius
commented
Dec 7, 2021
Pinging maintainers... I believe this is ready to merge and is necessary for JRuby 9.4 to source io-wait (and the net/* libraries that use it) from the gems. High priority for JRuby 9.4 release in the next month or two. |
Uh oh!
There was an error while loading. Please reload this page.
headius
commented
Jan 27, 2022
I have updated this from master again. Is there anything else needed to merge? |
headius
commented
Jan 27, 2022
The omitted test has been un-omitted, since that issue was fixed in JRuby 9.3.1.0 (current is 9.3.3.0). |
Co-authored-by: Pavel Rosický <pdahorek@seznam.cz>
Missing OS and using bare version number '9.3'.
headius
commented
Feb 1, 2022
I rebased this on master and it will merge now. I'm fine with merge commit or squashed. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
headius
commented
Feb 2, 2022
I have addressed all review comments. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* use case/when for chained ifs * include only necessary files for JRuby
hsbt
commented
Feb 3, 2022
🎉 |
headius
commented
Feb 3, 2022
Thank you both! |
This imports the JRuby code for io/wait, with tests green (see caveat) and hooked up to CI.
One test is skipped on JRuby due to jruby/jruby#6852, which will be fixed in JRuby 9.3.1.0.
This support is needed to release a JRuby-specific io-wait gem, a dependency of net-protocol. Without JRuby support in this gem we can't use any of the other net* gems.