Skip to content

respect NO_COLOR environment variable - #105

Merged
aycabta merged 2 commits into
ruby:masterfrom
mddelk:no-color
May 24, 2021
Merged

respect NO_COLOR environment variable#105
aycabta merged 2 commits into
ruby:masterfrom
mddelk:no-color

Conversation

@mddelk

@mddelkmddelk commented May 18, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

When NO_COLOR is set to any non-nil value, output is not colorized.

See https://no-color.org/

@mddelk
respect NO_COLOR environment variable
401d091
When `NO_COLOR` is set to any non-nil value, output is not colorized.
See https://no-color.org/
@mddelk
mddelk marked this pull request as ready for review May 18, 2020 02:04
@nobu

nobu commented May 18, 2020

Copy link
Copy Markdown
Member

From that site:

While some developers and users obviously prefer seeing these colors, many users don’t.

Just out of curiosity, how "many users" in percentage?

And are bold and underline included in NO_COLOR?

@mddelk

mddelk commented May 18, 2020

Copy link
Copy Markdown
ContributorAuthor

While some developers and users obviously prefer seeing these colors, many users don’t.

I expect this is a very small amount of people, myself not included. Maybe just one or two crazy people.

And are bold and underline included in NO_COLOR?

My interpretation is that NO_COLOR would not prohibit bold, underline, flashing, etc. It should only prohibit color.

Since so few people use it, feel free to close if you think it will just add more maintenance burden.

I only added it after I saw the --colorize option, and thought, does irb know about NO_COLOR?.

nobu
nobu reviewed Aug 12, 2020
View reviewed changes
Comment threadtest/irb/test_init.rb Outdated
@mddelk@nobu
update test/irb/test_init.rb to avoid useless eval
2dfdc03
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
@aycabta
aycabta merged commit 9c19899 into ruby:masterMay 24, 2021
@mddelk
mddelk deleted the no-color branch May 25, 2021 02:15
ko1 added a commit to ruby/debug that referenced this pull request Jul 8, 2022
@ko1
Respect NO_COLOR environment variable
641125c
irb seems supported `NO_COLOR` so debug.gem also support it.
ref: https://no-color.org/
ref: ruby/irb#105
@ko1ko1 mentioned this pull request Jul 8, 2022
Merged
ko1 added a commit to ruby/debug that referenced this pull request Jul 8, 2022
@ko1
Respect NO_COLOR environment variable
a4c58f3
irb seems supported `NO_COLOR` so debug.gem also support it.
ref: https://no-color.org/
ref: ruby/irb#105
st0012 pushed a commit to ruby-tooling/ruby-debugger that referenced this pull request Jul 10, 2022
@ko1@st0012
Respect NO_COLOR environment variable
d084877
irb seems supported `NO_COLOR` so debug.gem also support it.
ref: https://no-color.org/
ref: ruby/irb#105
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nobunobunobu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mddelk@nobu@aycabta