Skip to content

[PoC] Support dialog theme/color configuration - #380

Closed
st0012 wants to merge 2 commits into
ruby:masterfrom
st0012:support-dialog-color-configuration
Closed

[PoC] Support dialog theme/color configuration#380
st0012 wants to merge 2 commits into
ruby:masterfrom
st0012:support-dialog-color-configuration

Conversation

@st0012

@st0012st0012 commented Jul 23, 2022

Copy link
Copy Markdown
Member

See https://bugs.ruby-lang.org/issues/19010

Todos

If we want to proceed on this idea, we have the following todos:

  • Add test cases
  • Release reline 0.4.0 for the new APIs
  • Bump reline requirement and drop Ruby 2.5 support because reline now requires 2.6+
    • This includes CI changes
  • Add documentation
  • Automatic background detection to toggle bright theme

@st0012

Copy link
Copy Markdown
MemberAuthor

cc @peterzhu2118@nobu@hsbt

@peterzhu2118peterzhu2118 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like having themes. Makes the UX better.

Comment threadlib/irb/context.rb
@st0012
st0012force-pushed the support-dialog-color-configuration branch from a96074f to 3a44f1cCompareSeptember 18, 2022 21:55
@st0012
st0012force-pushed the support-dialog-color-configuration branch from 3a44f1c to 81a3583CompareSeptember 18, 2022 22:07
@st0012st0012 closed this Dec 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@st0012@peterzhu2118