Skip to content

Implement history command - #761

Merged
tompng merged 13 commits into
ruby:masterfrom
garyhtou-forks:garyhtou/hist-command
Dec 2, 2023
Merged

Implement history command#761
tompng merged 13 commits into
ruby:masterfrom
garyhtou-forks:garyhtou/hist-command

Conversation

@garyhtou

@garyhtougaryhtou commented Nov 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds the history command (aliased as hist) which provides a list of previous IRB inputs. This supports multiline inputs but truncates them to two lines. Lines are displayed in reverse to show the most recent inputs first.

This command also supports grep (-g or -G option); similar to the ls command.

image

Closes#751

@garyhtou
Implement history command
e8d0fbf
Lists IRB input history with indices. Also aliased as `hist`.
@garyhtou
Add tests for history command
e240eb9
tompng
tompng reviewed Nov 14, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
tompng
tompng reviewed Nov 14, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
@st0012st0012 added the enhancement New feature or request label Nov 23, 2023
@st0012

st0012 commented Nov 29, 2023

Copy link
Copy Markdown
Member

@garyhtou 👋 I think once you addressed these 2 feedback, we'll be very close to merging this PR and make it part of Ruby 3.3 😉

@garyhtou

garyhtou commented Nov 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Oops, sorry for leaving this hanging. Thanks for the ping!

I'll wrap this up later tonight :)

garyhtou
garyhtou commented Nov 30, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
@garyhtou

garyhtou commented Nov 30, 2023

Copy link
Copy Markdown
ContributorAuthor

It appears the CI failure might be unrelated

#790

tompng
tompng reviewed Nov 30, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
tompng
tompng reviewed Nov 30, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
tompng
tompng reviewed Nov 30, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
tompng
tompng reviewed Nov 30, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
tompng
tompng reviewed Nov 30, 2023
View reviewed changes
Comment threadlib/irb/cmd/history.rb Outdated
tompng
tompng approved these changes Dec 2, 2023
View reviewed changes

@tompngtompng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 👍

@tompng
tompng merged commit 3f9eacb into ruby:masterDec 2, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Dec 2, 2023
@garyhtou@matzbot
[ruby/irb] Implement history command
4ee1f0f
(ruby/irb#761)
* Implement `history` command
Lists IRB input history with indices. Also aliased as `hist`.
* Add tests for `history` command
* Address feedback: `puts` with multiple arguments instead of `join`ing
* Address feedback: Handle nil from splitting an empty input string
* Refactor line truncation
* Add `-g` grep option to `history` command
* Add `history` command to README
* Remove unused `*args` parameter
* Allow spaces to be included in grep
* Allow `/` to be included in grep regex
* Handle `input` being an empty string
* Exclude "#{index}: " from matching the grep regex
* Add new line after joining
ruby/irb@3f9eacbfa9
@garyhtou
garyhtou deleted the garyhtou/hist-command branch December 2, 2023 06:05
@garyhtou

garyhtou commented Dec 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Thank you @tompng and @st0012 for helping guide me through this!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tompngtompngtompng approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support hist command

3 participants

@garyhtou@st0012@tompng