Skip to content

Support to become bundled gems - #113

Merged
hsbt merged 2 commits into
masterfrom
support-bundled-gems
Jan 10, 2025
Merged

Support to become bundled gems#113
hsbt merged 2 commits into
masterfrom
support-bundled-gems

Conversation

@hsbt

@hsbthsbt commented Jan 9, 2025

Copy link
Copy Markdown
Member

@hsbt
hsbtforce-pushed the support-bundled-gems branch 3 times, most recently from 4621018 to 9cb9f1cCompareJanuary 9, 2025 07:42
Comment threadtest/logger/test_logdevice.rb Outdated
r, w = IO.pipe
[w, *(1..n).map do
f = IO.popen([EnvUtil.rubybin, *%w[--disable=gems -rlogger -], *args], "w", err: w)
f = IO.popen([EnvUtil.rubybin, *%w[--disable=gems -I#{@top_lovel} -rlogger -], *args], "w", err: w)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this?

Suggested change
f=IO.popen([EnvUtil.rubybin, *%w[--disable=gems-I#{@top_lovel}-rlogger-], *args],"w",err: w)
f=IO.popen([EnvUtil.rubybin, *%w[--disable=gems-I#{@top_dir}-rlogger-], *args],"w",err: w)

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It's totally top_level's typo.

@hsbt
hsbtforce-pushed the support-bundled-gems branch from 9cb9f1c to a203879CompareJanuary 9, 2025 07:49
@hsbthsbt changed the title Added lib path to in assert_in_out_errSupport to become bundled gemsJan 9, 2025
@hsbt
hsbtforce-pushed the support-bundled-gems branch from 5810a76 to fba3ee3CompareJanuary 9, 2025 09:17
@hsbt
hsbt merged commit 663a27f into masterJan 10, 2025
@hsbt
hsbt deleted the support-bundled-gems branch January 10, 2025 01:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hsbt@olleolleolle