Uh oh!
There was an error while loading. Please reload this page.
allow setting shift variables in LogDevice when using reopen - #56
Merged
Conversation
nobu
requested changes
Feb 14, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue I raised in #55
The code in this PR allows setting parameters applicable to a log file in
LogDevice#reopenas well as during initialization.I only added the one test to demonstrate the functionality; please let me know what all you would like done here. Should I just copy/paste all of the applicable tests while replacing the constructor code with these 2 lines? Should I put it in a separate test file?