Uh oh!
There was an error while loading. Please reload this page.
🗑️ Add deprecation warnings to .new and #starttls - #119
Draft
nevans wants to merge 2 commits into
Draft
Conversation
nevansforce-pushed
the
deprecations-for-new-and-starttls
branch
2 times, most recently
from
July 26, 2023 02:52
e479952 to
1319d2aComparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
3 times, most recently
from
August 28, 2023 13:16
42a247d to
688fae2Comparenevans
marked this pull request as draft
August 28, 2023 13:21
nevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
August 29, 2023 14:31
688fae2 to
031fb0fComparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
7 times, most recently
from
October 5, 2023 14:01
cf830ef to
6cea168Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
2 times, most recently
from
November 7, 2023 04:38
2141292 to
de2244eComparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
January 2, 2024 17:18
de2244e to
dfffcfeComparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
2 times, most recently
from
June 22, 2024 16:07
e31b14e to
782cea8Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
June 26, 2024 14:52
782cea8 to
56befa6Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
October 12, 2024 14:40
56befa6 to
0cd91b4Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
October 29, 2024 18:12
0cd91b4 to
06c3ebaComparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
November 8, 2024 22:56
06c3eba to
272a3a5Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
December 23, 2024 22:38
272a3a5 to
3e070d8Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
February 13, 2025 14:41
3e070d8 to
350e96bComparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
April 24, 2025 13:15
350e96b to
ceb8c14Comparenevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
August 9, 2025 13:03
ceb8c14 to
cedc62eCompare* `ssl` was renamed to `tls` in most places, with backwards compatible aliases. Using `ssl` does not print any deprecation warnings. Using both `tls` and `ssl` keywords raises an ArgumentError. * Preparing for a (backwards-incompatible) secure-by-default configuration, `Net::IMAP.default_tls` will determine the value for `tls` when no explicit port or tls setting is provided. Using port 143 will be insecure by default. Using port 993 will be secure by default. Providing no explicit port will use `Net::IMAP.default_tls` with the appropriate port. And providing any other unknown port will use `default_tls` with a warning. 🚧 TODO: should we use a different config var for default tls params when port is 993 and `tls` is unspecified? 🚧 TODO: should we use a different config var for choosing `tls` when `port` is non-standard vs choosing `port` and `tls` when neither are specified? 🚧 TODO: should we use a different var for `default_tls` be used to config params when port is 993 but tls is implicit? Another var?
nevansforce-pushed
the
deprecations-for-new-and-starttls
branch
from
November 29, 2025 19:48
cedc62e to
240035bCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for a (backwards-incompatible) secure-by-default configuration, Net::IMAP.default_ssl will be used when no explicit port or TLS setting is provided.
TODO: should truthy default_ssl be used to config params when port is 993 but ssl is implicit? Another var?
Moved all deprecated option handling to DeprecatedClientOptions, which is prepended to Net::IMAP.
Additionally, split
initializeup into small helper methods making it easier to understand at a glance.This is a first step towards fixing #118.